fix: Apple Touch Icon being as browser icon #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlan-zw
changed the title
|
Hey @KyleSmith0905, thanks for your work on this. Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11
Apple Icons were classifying as normal icons, since they have the text "icon" included in them.
I prevented apple icons from being a normal icon.
I can imagine to a very small number people who are using this plugin incorrectly that it could be a breaking change, however it's probably like 1 person.
Linked Issues
#11
Additional context
I couldn't run a dev server to see if this worked, here is what I've tried for that:
pnpm run devNotices the dev server doesn't startpnpm run dev:prepare; pnpm run devgit checkout mainOk, I guess I'll try to see if it didn't work before my changespnpm run devStill doesn't seem to workpnpm run dev:prepare; pnpm run devhmmHowever, the code wasn't experimental, and I'm 90% sure it would work since I have a limited scope.
Tests passed, but I haven't edited tests to fail without this PR (partially because of the dev server thing).