Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling #17

Merged
merged 3 commits into from
Mar 18, 2024
+10 −10
Merged

fix: error handling #17

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8803d94
fix: typed data signature version
Feb 20, 2024
025bef3
fix: error handling
Mar 18, 2024
3a66488
Merge branch 'main' into fix/error-handling
Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: typed data signature version
iGroza committed Feb 20, 2024
commit 8803d941d98e87f7dd0004e950e7b4e078963789
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@haqq/provider-ledger-react-native",
"version": "0.0.26",
"version": "0.0.27",
"description": "Provider for react-native ledger",
"main": "dist/index.js",
"types": "dist/index.d.ts",
@@ -34,7 +34,7 @@
"react-native-ble-plx": "*"
},
"devDependencies": {
"@haqq/provider-base": "0.0.20",
"@haqq/provider-base": "0.0.22",
"@ledgerhq/types-devices": "^6.23.0",
"@types/jest": "^29.4.0",
"@types/node": "^18.14.1",
3 changes: 2 additions & 1 deletion src/provider.ts
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {TransactionRequest} from '@ethersproject/abstract-provider';
import {
calcTypedDataSignatureV,
compressPublicKey,
prepareHashedEip712Data,
stringToUtf8Bytes,
@@ -201,7 +202,7 @@ export class ProviderLedgerReactNative

run()
.then(result => {
o.next(result);
o.next(calcTypedDataSignatureV(result));
o.complete();
this.emit('signTypedData', true);
})
8 changes: 4 additions & 4 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -1184,10 +1184,10 @@
dependencies:
"@hapi/hoek" "^9.0.0"

"@haqq/provider-base@0.0.20":
version "0.0.20"
resolved "https://registry.yarnpkg.com/@haqq/provider-base/-/provider-base-0.0.20.tgz#34d3d6c8a564da54f60c5586da1ef2efb4bec713"
integrity sha512-UUbuLzZN/GH5K50NY8DDHNUaJ3u0DEVnNq/8JGmloTxlMGkYP+nHikXAKA6jXDapToNmFQEjjqtUCkHA17ri3w==
"@haqq/provider-base@0.0.22":
version "0.0.22"
resolved "https://registry.yarnpkg.com/@haqq/provider-base/-/provider-base-0.0.22.tgz#04ec83a52b7fbbf85e28914950cd484498937664"
integrity sha512-RjHhmNroC8kV29u2yjuTpgH0Cy0z425exzcMCXYXsV2z+NHxPptNA2W/hzXejMh6HV03BqnGEfWGBu4cCorniQ==
dependencies:
bech32-converting "^1.0.9"
ethers "^5.7.2"