Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile for GCP CloudSql Postgres driver #676

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Add profile for GCP CloudSql Postgres driver #676

merged 3 commits into from
Apr 21, 2024

Conversation

jakubadamek
Copy link
Contributor

No description provided.

@jkiddo
Copy link
Collaborator

jkiddo commented Apr 15, 2024

Please add a comment in the poem that this profile also needs eg. the boot profile to work

@jkiddo jkiddo requested a review from dotasek April 15, 2024 20:10
@jakubadamek
Copy link
Contributor Author

Please add a comment in the poem that this profile also needs eg. the boot profile to work

Thanks, done

@dotasek
Copy link
Contributor

dotasek commented Apr 16, 2024

Is there a way to test what this new dependency adds to the functionality? (example configs, start params, etc.?)

@jakubadamek
Copy link
Contributor Author

Is there a way to test what this new dependency adds to the functionality? (example configs, start params, etc.?)

Yes, I use it by filling in application.yaml:

datasource:
url: jdbc:postgresql:///patients_79?cloudSqlInstance=&socketFactory=com.google.cloud.sql.postgres.SocketFactory

This is also described here: https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/blob/main/docs/jdbc.md#postgres-1

jkiddo
jkiddo reviewed Apr 21, 2024
View reviewed changes
pom.xml Outdated
@@ -676,5 +676,16 @@
</plugins>
</build>
</profile>
<!-- For connecting to GCP CloudSQL Postgres instances. Needs 'boot' profile as well. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider putting the link you found here as well (the https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/blob/main/docs/jdbc.md#postgres-1 one)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jkiddo jkiddo merged commit 4e2faee into hapifhir:master Apr 21, 2024
3 checks passed
ArtyomyuS pushed a commit to angels-on-earth/aoe-fhir-service that referenced this pull request May 7, 2024
@jakubadamek
Add profile for GCP CloudSql Postgres driver (hapifhir#676)
e971bf8 
* Add profile for GCP CloudSql Postgres driver

* Update pom.xml: comment on cloudsql-postgres profile needs boot profile

* Add link to GCP docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkiddo jkiddo jkiddo approved these changes

@dotasek dotasek Awaiting requested review from dotasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubadamek @jkiddo @dotasek