Fix some bugs + some improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the search depth I started notifying that the "good moves" starting being extremely bad. This could ofc mean overflow which was in fact the case. I was a bit naive with my previous implementation. Instead increase the scoring to use 32bit value to avoid over/underflows. Also printing the score from the evaluator always returning 0. Also fixed that bug. Signed-off-by: Hans Binderup <[email protected]>
Static inline has been abused a bit. Remove some and add some where needed. Signed-off-by: Hans Binderup <[email protected]>
Previously we would clear all tables for a given position when going for a new search. This is not necessary. We should only reset if position has changed. Signed-off-by: Hans Binderup <[email protected]>
This commit adds simple tests for killer moves. Signed-off-by: Hans Binderup <[email protected]>
This commit adds simple tests for history moves Signed-off-by: Hans Binderup <[email protected]>
This commit adds tests for PV table. Also it helped me find the bug I was looking for. Now the search seems good! Also, the compile_commands.json file was only symlinked if the build suceeded. Not very practical :) Signed-off-by: Hans Binderup <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hunting a search bug for a few days now. I could not get my head around what was actually causing it.
I fixed the evaluator print debugging -> clear that an over/underflow could happen on deeper searches.
The move sorting felt a bit weird, so I added tests for most of my heuristics. In the end I found the little bugger.. it was a copy paste error in the PVTable meaning that we never followed the PV line. Now the search is waay faster.