Add support for /time, dynamic start and end times #19
Conversation
Conceptron
commented
Dec 19, 2021
Conceptron
commented
- The start and end times are now calculated as the min / max of the start and end times of the events. This improves the use of space in the visualization
- Events can now use "x" as end times to represent current time
- The start and end times are now calculated as the min / max of the start and end times of the events. This improves the use of space in the visualization - Events can now use "x" as end times to represent current time
There was a problem hiding this comment.
Thanks for the contribution @Conceptron!
I like making the start and end time more dynamic and flexible! Although it
- removes some robustness, e.g. the user can enter
9999which is like 4 days and this makes it harder to tell what's going on. Maybe it's cool to be able to plan two consecutive days in a single diagram though! - It's harder to visualize your day, e.g. if you have configured the start and end time matching your working hours you have an empty block to fill. With purely dynamic start and end times the shown interval always changes.
I have not run the code myself yet, but it looks like start and end time are undefined/NaN when there are no time blocks yet?
Maybe we can still use DEFAULT_START_TIME and DEFAULT_END_TIME when (they are explicitly defined by the user AND the defined time blocks do not go out of this interval) OR there are no blocks yet (even if the user has not defined anything, then use 600, 2200 or similar). I think this would require changing the plugin settings mechanism.
I like the support for x in end times and ignoring : in time definitions!
I'll approve as I feel my concerns are overcomplicating things and I like the general changes!
src/lib/remnote-schedule.js
Outdated
| } else if (block.end === 'x') { | ||
| // get current time in hhmm format | ||
| const now = new Date(); | ||
| block.end = now.getHours() * 100 + (now.getMinutes() / 60) * 100; |
There was a problem hiding this comment.
What happens if the start time of this block is in the future? Then this block would be reversed.
What happens if there are multiple blocks ending in x. I think this is fine? It would be great if we had #12 then.
