GrouperView.join() no longer exists, use sharey() instead
#26
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arrays to scalars, could use .squeeze if preferred
…asterization of '<matplotlib.contour.QuadContourSet object at 0x11554dd10>' will be ignored
AdamOrmondroyd
commented
Jan 27, 2025
AdamOrmondroyd
commented
Jan 27, 2025
| @@ -98,12 +98,10 @@ def plot(x, y, z, ax=None, **kwargs): | |||
|
|
|||
| # Rasterize contours (the rest of the figure stays in vector format) | |||
| if rasterize_contours: | |||
| for c in cbar.collections: | |||
| c.set_rasterized(True) | |||
| cbar.set_rasterized(True) | |||
There was a problem hiding this comment.
getting warnings this hasn't been applied
williamjameshandley
previously approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Thank you so much @AdamOrmondroyd for sorting all this out. A lot of people use this code (particularly in REACH), so keeping it up to date is really valuable.
Please squash and merge.
|
Are you sure you're happy with the rasterizing bit? |
|
Sorry, realised I wasn't happy with using [0] instead of .squeeze(). Feel free to revert if your opinion differs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GrouperViewno longer has a.join()method, so usesharey()instead. https://stackoverflow.com/questions/77418896/attributeerror-grouperview-object-has-no-attribute-joinFixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: