JDK 17 Fixes #172
Open
JDK 17 Fixes #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@honza-kasik gentle ping :) |
honza-kasik
reviewed
Jun 2, 2022
There was a problem hiding this comment.
Thanks @spriadka ! Can you please send me a link to a test run?
pom.xml
Outdated
| @@ -426,7 +426,7 @@ | |||
| <jdk>[17,)</jdk> | |||
There was a problem hiding this comment.
JPMS properties are AFAIK valid for JDK 11+
OndrejKotek
reviewed
Jun 6, 2022
|
@honza-kasik I've adjusted the profile to be JDK11+. I suggest addressing issues with the |
|
@spriadka Has there been any other MR or thread regarding JDK17 / the Spotbugs plugin in the meantime? |
spriadka
force-pushed
the
jdk-17-support
branch
from
57a8281 to
7aba388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.