Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/schema sql based on uml book lebel #37

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

hafiz1379
Copy link
Owner

Feature: Database Schema Definition with Books and Labels Tables

Summary

This PR introduces a schema.sql file that defines the database schema with two tables: Books and Labels. The schema design closely mirrors the structure of the classes created in the project, incorporating properties and associations from the parent Item class as table columns.

Changes Made

Database Schema Definition

  • Created a schema.sql file to define the database schema.
  • Introduced the following tables with corresponding columns:
    • Books Table: Modeled after the properties and associations from the parent Item class, including all relevant columns.
    • Labels Table: Designed to accommodate label information.

Reviewer's Notes

I invite the code reviewer to thoroughly examine the schema.sql file and ensure that it accurately represents the structure of the classes created in the project. Please verify that the table columns match the properties and associations as specified. Your feedback on schema design and correctness is highly appreciated. Thank you for taking the time to review this PR.

@hafiz1379 hafiz1379 linked an issue Oct 18, 2023 that may be closed by this pull request
2 tasks
@JuanDiegoGuerra JuanDiegoGuerra self-requested a review October 18, 2023 13:24
Copy link
Collaborator

@JuanDiegoGuerra JuanDiegoGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hafiz1379 👋 👋,

This PR is completed! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

STATUS: APPROVED ✔✔

database

🎯 TOP HIGHLIGHTS 🎯

  • Cleanly written code. ✅
  • Nicely implemented Tables into DB schema. ✅

@hafiz1379
Copy link
Owner Author

Thank you @JuanDiegoGuerra

@hafiz1379 hafiz1379 merged commit ba92642 into dev Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt]Team member #1 - Task 7 - Create a schema.sql
2 participants