Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fsharp-analyzers suggestions #509

Merged
merged 1 commit into from
Aug 24, 2024
Merged

A few fsharp-analyzers suggestions #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Expecto/Expecto.Impl.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ module Impl =
else
let nestedFunc =
t.GetTypeInfo().GetFields()
|> Seq.tryFind (fun f -> isFsharpFuncType f.FieldType)
|> Array.tryFind (fun f -> isFsharpFuncType f.FieldType)
match nestedFunc with
| Some f -> f.GetValue(testFunc).GetType()
| None -> t
Expand All @@ -969,7 +969,7 @@ module Impl =
match testCode with
| Sync test ->
let t = getFuncTypeToUse test asm
let m = t.GetTypeInfo().GetMethods () |> Seq.find (fun m -> (m.Name = "Invoke") && (m.DeclaringType = t))
let m = t.GetTypeInfo().GetMethods () |> Array.find (fun m -> (m.Name = "Invoke") && (m.DeclaringType = t))
(t.FullName, m.Name)
| SyncWithCancel _ ->
("Unknown SyncWithCancel", "Unknown SyncWithCancel")
Expand Down
2 changes: 1 addition & 1 deletion Expecto/Expecto.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ module Tests =
match Args.parseOptions options args with
| Ok cliArguments ->
let config =
Seq.fold (fun s a -> foldCLIArgumentToConfig a s) baseConfig cliArguments
List.fold (fun s a -> foldCLIArgumentToConfig a s) baseConfig cliArguments
if List.exists(function List_Tests _ -> true | _ -> false) cliArguments then
ArgsList config
elif List.contains Version cliArguments then
Expand Down
Loading