Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unusable replay seed with FsCheck3 #501

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

rynoV
Copy link
Contributor

@rynoV rynoV commented Aug 9, 2024

When using FsCheck3 it was impossible to use the replay seeds given in the failed test output because the config values only accepted int32, instead of uint64

RELEASE_NOTES.md Outdated
@@ -1,3 +1,6 @@
### 11.0.0 - 2024-08-09
* Fix unusable replay seed with FsCheck3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change, the release notes should be more descriptive of the breaking change.
Perhaps something like

Breaking Change: move FsCheckConfig.replay from int to uint64. 
Fixes issue where many FsCheck3 runs could not be replayed since the random seed is too large. 
Existing FsCheck 2 users should be able to use the same seeds values, but converted to uint64. 
Uint64 literals can be defined like `let iAm5 = 5UL` 

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. The ReadMe also needs updated with the new replay type. Probably also with update guidance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated thanks, let me know if there's anything I missed

@farlee2121
Copy link
Collaborator

Thanks for the PR. Definitely a shortcoming of the original solution.

I notice that FsCheck seems to be pushing toward releasing version 3.

but 3.x is the version that is currently maintained. Only v3 will get new features and fixes, even though it's in pre-release.

Perhaps it's time to make fscheck 3 the main Expecto.FsCheck?

@rynoV
Copy link
Contributor Author

rynoV commented Aug 12, 2024

Perhaps it's time to make fscheck 3 the main Expecto.FsCheck?

This seems reasonable to me, I don't use fscheck 2

@farlee2121
Copy link
Collaborator

Thanks for the updates. I haven't looked at them yet, but I'll try to do it this week.

@farlee2121 farlee2121 merged commit bc14bbb into haf:main Aug 15, 2024
2 checks passed
@farlee2121
Copy link
Collaborator

11.0.0-alpha1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants