-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unusable replay seed with FsCheck3 #501
Conversation
RELEASE_NOTES.md
Outdated
@@ -1,3 +1,6 @@ | |||
### 11.0.0 - 2024-08-09 | |||
* Fix unusable replay seed with FsCheck3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a breaking change, the release notes should be more descriptive of the breaking change.
Perhaps something like
Breaking Change: move FsCheckConfig.replay from int to uint64.
Fixes issue where many FsCheck3 runs could not be replayed since the random seed is too large.
Existing FsCheck 2 users should be able to use the same seeds values, but converted to uint64.
Uint64 literals can be defined like `let iAm5 = 5UL`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. The ReadMe also needs updated with the new replay type. Probably also with update guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated thanks, let me know if there's anything I missed
Thanks for the PR. Definitely a shortcoming of the original solution. I notice that FsCheck seems to be pushing toward releasing version 3.
Perhaps it's time to make fscheck 3 the main Expecto.FsCheck? |
This seems reasonable to me, I don't use fscheck 2 |
Thanks for the updates. I haven't looked at them yet, but I'll try to do it this week. |
11.0.0-alpha1 is out |
When using FsCheck3 it was impossible to use the replay seeds given in the failed test output because the config values only accepted
int32
, instead ofuint64