Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fsharp-analyzers suggestions #509

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Aug 23, 2024

I tried running the Expecto library code through a few fsharp-analyzers, and got a few suggested changes.
These ones are from https://g-research.github.io/fsharp-analyzers/analyzers/VirtualCallAnalyzer.html where it suggests replacing Seq functions with explicit types when the collection types are fixed:


Expecto.Impl.fs(963,11): Warning GRA-VIRTUALCALL-001 : Consider replacing the call of Seq.tryFind with a function from the Array module to avoid the costs of virtual calls.
Expecto.Impl.fs(972,47): Warning GRA-VIRTUALCALL-001 : Consider replacing the call of Seq.find with a function from the Array module to avoid the costs of virtual calls.
Expecto.fs(546,12): Warning GRA-VIRTUALCALL-001 : Consider replacing the call of Seq.fold with a function from the List module to avoid the costs of virtual calls.

Any thoughts?

@farlee2121
Copy link
Collaborator

I don't see any issue with this. It's not affecting any type inference.

@farlee2121 farlee2121 merged commit 0608864 into haf:main Aug 24, 2024
2 checks passed
@Numpsy Numpsy deleted the analysis_1 branch August 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants