Skip to content

Commit

Permalink
[APC Desktop] Expose flag for password change from settings on Desktop.
Browse files Browse the repository at this point in the history
Bug: 1316316
Change-Id: I033681c602706df17445502cc8a0e33fe7a2aa7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3720663
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1017596}
  • Loading branch information
Jan Keitel authored and Chromium LUCI CQ committed Jun 24, 2022
1 parent fc9d331 commit 7babdb5
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2523,7 +2523,6 @@ const FeatureEntry::FeatureVariation kPasswordChangeFeatureVariations[] = {
kPasswordChangeVariationWithForcedDialogAfterEverySuccessfulSubmission),
nullptr}};

#if BUILDFLAG(IS_ANDROID)
// The variations of --password-change-in-settings.
const FeatureEntry::FeatureParam
kPasswordChangeInSettingsVariationWithForcedWarningForEverySite[] = {
Expand All @@ -2539,6 +2538,7 @@ const FeatureEntry::FeatureVariation
kPasswordChangeInSettingsVariationWithForcedWarningForEverySite),
nullptr}};

#if BUILDFLAG(IS_ANDROID)
// The variations of --touch-to-fill-password-submission.
const FeatureEntry::FeatureParam
kTouchToFillPasswordSubmissionWithConservativeHeuristics[] = {
Expand Down Expand Up @@ -6936,20 +6936,19 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_WITH_PARAMS_VALUE_TYPE(password_manager::features::kPasswordChange,
kPasswordChangeFeatureVariations,
"PasswordChangeFeatureVariations")},

#if BUILDFLAG(IS_ANDROID)
{"password-change-in-settings",
flag_descriptions::kPasswordChangeInSettingsName,
flag_descriptions::kPasswordChangeInSettingsDescription, kOsAndroid,
flag_descriptions::kPasswordChangeInSettingsDescription, kOsAll,
FEATURE_WITH_PARAMS_VALUE_TYPE(
password_manager::features::kPasswordChangeInSettings,
kPasswordChangeInSettingsFeatureVariations,
"PasswordChangeInSettingsFeatureVariations")},

#if BUILDFLAG(IS_ANDROID)
{"password-scripts-fetching",
flag_descriptions::kPasswordScriptsFetchingName,
flag_descriptions::kPasswordScriptsFetchingDescription, kOsAndroid,
FEATURE_VALUE_TYPE(password_manager::features::kPasswordScriptsFetching)},

#endif // BUILDFLAG(IS_ANDROID)

#if BUILDFLAG(IS_ANDROID)
Expand Down

0 comments on commit 7babdb5

Please sign in to comment.