Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] - Improve ban buttons #136

Merged

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This PR improves the usability from the ban decision buttons.

  • Approve can only be clicked once
  • Disapprove can only be clicked once (will grey out all buttons as the user is unbanned immediately

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

…ill grey out)

- Disapprove can only be clicked once (will grey out all buttons as the user is unbanned immediately
@janssensjelle janssensjelle changed the title [FEATURE] - Improve ban buttons [IMPROVEMENT] - Improve ban buttons Jan 19, 2025
Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvement!

@dimoschi dimoschi merged commit 4228075 into hackthebox:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants