Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Added validation for CAPE cert #132

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Adds the CAPE certification and role. This was added in .test.env

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (2af5093) to head (d0a28ff).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/verification.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   53.20%   53.15%   -0.05%     
==========================================
  Files          43       43              
  Lines        2453     2455       +2     
==========================================
  Hits         1305     1305              
- Misses       1148     1150       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makelarisjr makelarisjr merged commit 7088d37 into hackthebox:main Dec 19, 2024
2 of 3 checks passed
@janssensjelle janssensjelle deleted the feature/CAPE-certification branch December 25, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants