-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📱 Tap to Pay Donations #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see feedback about this here: https://docs.google.com/document/d/1aHkG78ChjvCzlrwnsFoNXvQMepeTKaQgz9Xc4Ms7ETk/edit?usp=sharing
Please ensure the CI checks pass on the files that you have changed before merging. Do not edit other files to make them pass as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the merge conflicts and disable menu option and entitlement :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YodaLightsabr can you fix the merge conflicts and then disable the entitlement and button in the UI for now? I want to get this merged so it doesn't pile up with more conflicts when we go to lint and prettify the codebase so we can reenable CI. We'll make a separate PR when we have the entitlement and are ready to enable tap-to-pay.
It looks like these bugs/requests have not been fixed/implemented yet. https://docs.google.com/document/d/1aHkG78ChjvCzlrwnsFoNXvQMepeTKaQgz9Xc4Ms7ETk/edit?tab=t.0#heading=h.iipvu8mtji5x |
@yednapg We are merging this PR but disabling the feature until the bugs Ruien specified are fixed. We just wanna merge all PRs rn so we can start the process of linting & prettierifing our code and then we can reenable CI workflows for PRs :) |
Cool |
Adds Tap to Pay support for donations on iPhone (and maybe Android?)