Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📱 Tap to Pay Donations #8

Merged
merged 17 commits into from
Jan 14, 2025
Merged

📱 Tap to Pay Donations #8

merged 17 commits into from
Jan 14, 2025

Conversation

YodaLightsabr
Copy link
Contributor

@YodaLightsabr YodaLightsabr commented Sep 5, 2024

Adds Tap to Pay support for donations on iPhone (and maybe Android?)

@Luke-Oldenburg Luke-Oldenburg changed the title 📱 Tap to Pay on iPhone! 📱 Tap to Collect Donations Dec 8, 2024
@YodaLightsabr YodaLightsabr changed the title 📱 Tap to Collect Donations 📱 Tap to Pay Donations Dec 8, 2024
Copy link

@rluodev rluodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Luke-Oldenburg
Copy link
Collaborator

Please ensure the CI checks pass on the files that you have changed before merging. Do not edit other files to make them pass as well.

@Luke-Oldenburg Luke-Oldenburg added the enhancement New feature or request label Jan 2, 2025
Copy link
Collaborator

@thedev132 thedev132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the merge conflicts and disable menu option and entitlement :)

Copy link
Collaborator

@Luke-Oldenburg Luke-Oldenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YodaLightsabr can you fix the merge conflicts and then disable the entitlement and button in the UI for now? I want to get this merged so it doesn't pile up with more conflicts when we go to lint and prettify the codebase so we can reenable CI. We'll make a separate PR when we have the entitlement and are ready to enable tap-to-pay.

@yednapg
Copy link
Collaborator

yednapg commented Jan 14, 2025

It looks like these bugs/requests have not been fixed/implemented yet. https://docs.google.com/document/d/1aHkG78ChjvCzlrwnsFoNXvQMepeTKaQgz9Xc4Ms7ETk/edit?tab=t.0#heading=h.iipvu8mtji5x

@thedev132 thedev132 requested a review from a team as a code owner January 14, 2025 05:27
@thedev132
Copy link
Collaborator

@yednapg We are merging this PR but disabling the feature until the bugs Ruien specified are fixed. We just wanna merge all PRs rn so we can start the process of linting & prettierifing our code and then we can reenable CI workflows for PRs :)

@yednapg
Copy link
Collaborator

yednapg commented Jan 14, 2025

@yednapg We are merging this PR but disabling the feature until the bugs Ruien specified are fixed. We just wanna merge all PRs rn so we can start the process of linting & prettierifing our code and then we can reenable CI workflows for PRs :)

Cool

@Luke-Oldenburg Luke-Oldenburg dismissed their stale review January 14, 2025 13:14

Allow for merge

@Luke-Oldenburg Luke-Oldenburg merged commit 65d1004 into main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants