Full upgrade #192
Closed
Full upgrade #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `dict.get('key') or True` means that key can never be False! And in other cases, it's just clearer and more compact to use the default parameter.
…asy in future. Adopt FlaskForm and CSRFProtect to avoid deprecation warnings. Tweak config in create_app() so code works with Flask 1.0+.
|
Ugh, too many commits included. |
|
The non-passing test was for cyclomatic complexity which means that there are too many conditional branches in the function. I don't mind that there is a higher number of branches here since it is a setup function. Wrt to too many commits, I don't mind about that either. Reopening this PR since it is a much-needed upgrade to this project (feel free to close again/open up another PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade all the dependent libraries to address #182, #180, #184. I've also included pipupgrade to make this less of a chore in the future.