Merge pull request bugthesystem#13 from pjhuck/delete

Remove DeleteResponse

FireSharp.Tests/FirebaseClientTests.cs

@@ -114,7 +114,6 @@ public async void Delete()
 
             var response = await _firebaseClient.DeleteAsync("todos");
             Assert.NotNull(response);
-            Assert.AreEqual(response.Success, true);
         }
 
         [Test]

FireSharp.Tests/FiresharpTests.cs

@@ -21,8 +21,8 @@ public class FiresharpTests : TestBase
         [TestFixtureSetUp]
         public async void TestFixtureSetUp()
         {
-            Task<DeleteResponse> task1 = _client.DeleteAsync("todos");
-            Task<DeleteResponse> task2 = _client.DeleteAsync("fakepath");
+            Task<FirebaseResponse> task1 = _client.DeleteAsync("todos");
+            Task<FirebaseResponse> task2 = _client.DeleteAsync("fakepath");
             await Task.WhenAll(task1, task2);
         }
 
@@ -48,7 +48,6 @@ public async Task DeleteAsync()
 
             var response = await _client.DeleteAsync("todos/pushAsync");
             Assert.NotNull(response);
-            Assert.IsTrue(response.Success);
         }
 
         [Test, Category("INTEGRATION"), Category("ASYNC")]
@@ -172,7 +171,6 @@ public void Delete()
 
             var response = _client.Delete("todos/push");
             Assert.NotNull(response);
-            Assert.IsTrue(response.Success);
         }
 
         [Test, Category("INTEGRATION"), Category("SYNC")]

FireSharp/FireSharp.csproj

@@ -88,7 +88,6 @@
     <Compile Include="Interfaces\IFirebaseClient.cs" />
     <Compile Include="Interfaces\IRequestManager.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
-    <Compile Include="Response\DeleteResponse.cs" />
     <Compile Include="Response\EventRootResponse.cs" />
     <Compile Include="Response\EventStreamResponse.cs" />
     <Compile Include="Response\FirebaseResponse.cs" />

FireSharp/FirebaseClient.cs

@@ -83,14 +83,14 @@ public PushResponse Push<T>(string path, T data)
             }
         }
 
-        public DeleteResponse Delete(string path)
+        public FirebaseResponse Delete(string path)
         {
             try
             {
                 HttpResponseMessage response = _requestManager.Delete(path);
                 string content = response.Content.ReadAsStringAsync().Result;
                 HandleIfErrorResponse(response.StatusCode, content);
-                return new DeleteResponse(content, response.StatusCode);
+                return new FirebaseResponse(content, response.StatusCode);
             }
             catch (HttpRequestException ex)
             {
@@ -158,14 +158,14 @@ public async Task<PushResponse> PushAsync<T>(string path, T data)
             }
         }
 
-        public async Task<DeleteResponse> DeleteAsync(string path)
+        public async Task<FirebaseResponse> DeleteAsync(string path)
         {
             try
             {
                 HttpResponseMessage response = await _requestManager.DeleteAsync(path);
                 string content = await response.Content.ReadAsStringAsync();
                 HandleIfErrorResponse(response.StatusCode, content);
-                return new DeleteResponse(content, response.StatusCode);
+                return new FirebaseResponse(content, response.StatusCode);
             }
             catch (HttpRequestException ex)
             {

FireSharp/Interfaces/IFirebaseClient.cs

@@ -12,12 +12,12 @@ public interface IFirebaseClient
         Task<EventRootResponse<T>> OnChangeGetAsync<T>(string path, ValueRootAddedEventHandler<T> added = null);
         Task<SetResponse> SetAsync<T>(string path, T data);
         Task<PushResponse> PushAsync<T>(string path, T data);
-        Task<DeleteResponse> DeleteAsync(string path);
+        Task<FirebaseResponse> DeleteAsync(string path);
         Task<FirebaseResponse> UpdateAsync<T>(string path, T data);
         FirebaseResponse Get(string path);
         SetResponse Set<T>(string path, T data);
         PushResponse Push<T>(string path, T data);
-        DeleteResponse Delete(string path);
+        FirebaseResponse Delete(string path);
         FirebaseResponse Update<T>(string path, T data);
 
         [Obsolete("This method is obsolete use OnAsync instead.")]