chore: do npm publish on release event #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e271828-
reviewed
Mar 20, 2024
e271828-
reviewed
Mar 20, 2024
e271828-
reviewed
Mar 20, 2024
e271828-
reviewed
Mar 20, 2024
e271828-
reviewed
Mar 20, 2024
Co-authored-by: e271828- <[email protected]>
CAMOBAP
commented
Apr 4, 2024
e271828-
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve release workflow and make it more deterministic
How it was before
Once we did a tag CI will initiate release of the package regardless of where this tag appears on feature branch or on master. Which may be confusing if we did version bump PR with tag on it and even before the review is passed it will do release
After this PR
The tag creation will not initiate the release process, but once you created the release in https://github.com/hCaptcha/react-native-hcaptcha/releases this will initiate the release on CI