Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMI-11582] Add start_date #105

Merged
merged 1 commit into from
Oct 22, 2023
Merged

[IMI-11582] Add start_date #105

merged 1 commit into from
Oct 22, 2023

Conversation

RafalBielickiIM
Copy link
Contributor

No description provided.

DicksonChi
DicksonChi approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@DicksonChi DicksonChi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e271828-
e271828- requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you need both end_date and expiration_date? just keep expiration_date.

@RafalBielickiIM RafalBielickiIM force-pushed the IMI-11582 branch 2 times, most recently from d59619e to 22a8b80 Compare October 22, 2023 14:48
@RafalBielickiIM
Copy link
Contributor Author

why would you need both end_date and expiration_date? just keep expiration_date.

Removed end_date & changed start_date to timestamp (int)

@e271828- e271828- changed the title [IMI-11582] Add start_date & end_date [IMI-11582] Add start_date Oct 22, 2023
@RafalBielickiIM RafalBielickiIM merged commit c43f56b into master Oct 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DicksonChi DicksonChi DicksonChi approved these changes

@e271828- e271828- e271828- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafalBielickiIM @e271828- @DicksonChi