Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a macOS CI build.
The current Ubuntu build is not particularly meaningful because it does not install external dependencies and skips several tests. I addressed this by:
pomdp-solve
macOS binary. I attempted to build it from source but was unsuccessful (in both Ubuntu and macOS). I did not try the Ubuntu binary.tests/appl.patch
). I couldn't build it in Ubuntu (but didn't try very hard)POMDP_SOLVE_PATH
,POMDPCONVERT_PATH
, andPOMDP_SOLVE_PATH
. I think it's useful for these to exist in script form.Right now all 7 unit tests pass under macOS. I believe these are important features to facilitate future contributions to
pomdp-py
.