-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T473 Homepage & Misc Frontend Updates #516
Conversation
@maxturer I think it looks great! Apart from the issue Alex flagged, I'm not seeing any bugs. I'm going to try to merge this branch with the SAML/SSO branch, so that the latter will be up to date. |
One thing I've noted, which may not need to be fixed as part of this ticket, is that the authenticated works, while viewable as an authenticated user, do not have the download PDF button. You can still download the PDF from the file actions at the bottom, but the button is missing. |
That's interesting. I hadn't made any edits to any relevant templates that would cause that in this one, but I can take a look and see if it's solvable on the front end. |
Alright, once the CICD process finishes, this should be good to go! I have a couple other front end comments WRT the login page, but this PR is getting so large that we should talk about those and make another issue if needed. |
Woo! Just pulled and rechecked everything, and it looks good to me! 🫡 One day we might want to refactor to hardcode fewer things on the homepage, like the collections text and links, but that definitely sounds like a future iteration to me - especially while talks about collection stuff is still ongoing. |
Agreed, I'd been thinking said future iteration could have the collections and header content become content blocks editable in the UI via dashboard, like the standard hyrax "featured researcher" block. But good to know this is (finally) set for now |
It's the redesign!
PR contains:
To test, I suppose simply checking that I haven't left a file out of the commit (I don't think I did) by viewing the homepage, etc.