Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T473 Homepage & Misc Frontend Updates #516

Merged
merged 15 commits into from
Mar 7, 2024
Merged

Conversation

maxturer
Copy link
Contributor

@maxturer maxturer commented Mar 1, 2024

It's the redesign!
PR contains:

  • homepage styles & JS
  • replacement of button class names on all pages (including login pages)
  • replacement of a lot of other bootstrap class names to make way for custom code
  • moving of the "container" element to individual templates
  • temporary simplification of collections results
  • change in amount of recent displayed works
  • sitewide mobile-responsive fixes
  • and, likely, more

To test, I suppose simply checking that I haven't left a file out of the commit (I don't think I did) by viewing the homepage, etc.

@dolsysmith
Copy link
Contributor

@maxturer I think it looks great! Apart from the issue Alex flagged, I'm not seeing any bugs. I'm going to try to merge this branch with the SAML/SSO branch, so that the latter will be up to date.

@dolsysmith
Copy link
Contributor

One thing I've noted, which may not need to be fixed as part of this ticket, is that the authenticated works, while viewable as an authenticated user, do not have the download PDF button. You can still download the PDF from the file actions at the bottom, but the button is missing.

@maxturer
Copy link
Contributor Author

maxturer commented Mar 4, 2024

That's interesting. I hadn't made any edits to any relevant templates that would cause that in this one, but I can take a look and see if it's solvable on the front end.

@maxturer
Copy link
Contributor Author

maxturer commented Mar 4, 2024

Alright, once the CICD process finishes, this should be good to go! I have a couple other front end comments WRT the login page, but this PR is getting so large that we should talk about those and make another issue if needed.
Let me know if I've missed anything in my rails research scramble.

@alepbloyd
Copy link
Contributor

Woo! Just pulled and rechecked everything, and it looks good to me! 🫡

One day we might want to refactor to hardcode fewer things on the homepage, like the collections text and links, but that definitely sounds like a future iteration to me - especially while talks about collection stuff is still ongoing.

@maxturer
Copy link
Contributor Author

maxturer commented Mar 7, 2024

Agreed, I'd been thinking said future iteration could have the collections and header content become content blocks editable in the UI via dashboard, like the standard hyrax "featured researcher" block. But good to know this is (finally) set for now

@maxturer maxturer merged commit e8a3b77 into master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GWSS home page: add orientation/welcome langauge; improve spotlighting
3 participants