Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor PSD module fixes #5015

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

titodalcanton
Copy link
Contributor

Minor fixes to docstrings and error messages in the PSD module. The only functional change is that an exception is now raised in a place where it should have been, but was not. Apart from that, no functional change here.

  • The author of this pull request confirms they will adhere to the code of conduct

Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to clarify these, a few herz->hertz typos needed, but thats it

pycbc/psd/__init__.py Outdated Show resolved Hide resolved
pycbc/psd/__init__.py Outdated Show resolved Hide resolved
pycbc/psd/__init__.py Outdated Show resolved Hide resolved
pycbc/psd/__init__.py Outdated Show resolved Hide resolved
pycbc/psd/analytical.py Outdated Show resolved Hide resolved
pycbc/psd/analytical.py Outdated Show resolved Hide resolved
pycbc/psd/analytical.py Outdated Show resolved Hide resolved
pycbc/psd/analytical.py Outdated Show resolved Hide resolved
@titodalcanton
Copy link
Contributor Author

Thanks, I swear I was trying to pay attention to the herz vs hertz difference :D

@titodalcanton titodalcanton enabled auto-merge (squash) January 22, 2025 09:18
@titodalcanton titodalcanton merged commit 9b3efda into gwastro:master Jan 22, 2025
29 of 30 checks passed
@titodalcanton titodalcanton deleted the minor-psd-module-fixes branch January 22, 2025 10:29
@titodalcanton titodalcanton added the documentation Updates to documentation label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants