Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vetoes in PyGRB efficiency and page_tables scripts #4978

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

pannarale
Copy link
Contributor

@pannarale pannarale commented Dec 7, 2024

This PR is the tenth in the series started in PR #4929. Much like PRs #4947, #4950, #4955, and #4958, this PR provides versions of pycbc_pygrb_efficiency and pycbc_pygrb_page_tables that use veto and segments files, as well as the utilities introduced recently to streamline the PyGRB results scripts.

This PR also fixes a bug with the index used to look up template chirp masses (around line 406 of pycbc_pygrb_page_tables).

I reccomend looking at this after https://github.com/gwastro/pycbc/pull/4977/files, because the background generation is similar.

Standard information about the request (and the following ones that will be linked to this)

This is a: a new feature enabling veto definer file usage in PyGRB. Utilities and scripts in results production are being streamlined along the way.

This change affects: PyGRB

This change changes: result presentation / plotting and scientific output.

Motivation

Now that the workflow generator passes the veto definer file to the jobs where needed, its usage in the PyGRB results scripts is possible.

Testing performed

The totality of the changes that will be broken down in multiple PRs was tested on GRB 170817A data by producing a full results webpage (see here).

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale added the PyGRB PyGRB development label Dec 7, 2024
@pannarale pannarale self-assigned this Dec 7, 2024
@pannarale
Copy link
Contributor Author

pannarale commented Dec 9, 2024

@Thomas-JACQUOT, the commit above is the fix to the issue you found in your 2IFO run and raised with @sebastiangomezlopez ebastian.
Would you mind checking if it fixes your run? You would have to

  1. copy page_tables locally from the environment you used
  2. run it from command line and reproduce the error you are seeing
  3. apply the same one line fix given here and
  4. run again.

If you have difficulties finding the command line to run, just let me know.

Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me.

@pannarale pannarale enabled auto-merge (squash) December 10, 2024 12:12
@pannarale pannarale merged commit 1929bc2 into gwastro:master Dec 10, 2024
29 checks passed
@pannarale pannarale deleted the pygrb_vetoes_efficiency_tables branch December 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants