-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* function to allow X.Y for use action. refs #3 #31
Conversation
Thanks! But that code broke tests :( See https://travis-ci.org/guedes/pgvm/builds/3938373/#L98 |
Ah... Your test wait exit code different that I wrote. Ok, I will fix and commit again. 👍 |
guedes, I check the Travis test and I believe that the test need to change. # failed: match = /^version 999 is not installed$/ This case will be more right pgvm to return: $ pgvm use 999 Select a specific version of PostgreSQL to use. Usage: pgvm use X.Y.Z where X.Y.Z is the semantic version of a installed PostgreSQL E.g. ~$ pgvm use 9.1.4 TIP: you can use 'pgvm list' to see the PostgreSQL installations available. This because in return said as would to use argument. What do you think? |
But we should tell user when a version passed as argument isn't installed. Feel free to change the tests to rely on that, but we should avoid broke things. We should remember that in the future user will call |
Sure. I believe that is possible to make use 9this now. I will be work this. |
Nice, please fix the broken test "$ pgvm use 999" and create a new test to this issue. Thanks! |
use
action to allow X.Y args instead X.Y.Z for version #3