Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* function to allow X.Y for use action. refs #3 #31

Closed
wants to merge 7 commits into from
Closed

* function to allow X.Y for use action. refs #3 #31

wants to merge 7 commits into from

Conversation

fike
Copy link
Contributor

@fike fike commented Jan 3, 2013

@guedes
Copy link
Owner

guedes commented Jan 4, 2013

Thanks! But that code broke tests :( See https://travis-ci.org/guedes/pgvm/builds/3938373/#L98

@fike
Copy link
Contributor Author

fike commented Jan 4, 2013

Ah... Your test wait exit code different that I wrote. Ok, I will fix and commit again. 👍

@fike
Copy link
Contributor Author

fike commented Jan 4, 2013

guedes, I check the Travis test and I believe that the test need to change.

# failed: match = /^version 999 is not installed$/ 

This case will be more right pgvm to return:

$ pgvm use 999
Select a specific version of PostgreSQL to use.
Usage: pgvm use X.Y.Z
where X.Y.Z is the semantic version of a installed PostgreSQL
E.g.
   ~$ pgvm use 9.1.4
TIP: you can use 'pgvm list' to see the PostgreSQL
     installations available.

This because in return said as would to use argument. What do you think?

@guedes
Copy link
Owner

guedes commented Jan 6, 2013

But we should tell user when a version passed as argument isn't installed. Feel free to change the tests to rely on that, but we should avoid broke things. We should remember that in the future user will call use passing a major or middle version to it like use 9 or use 9.2.

@fike
Copy link
Contributor Author

fike commented Jan 8, 2013

Sure. I believe that is possible to make

use 9
this now. I will be work this.

@guedes
Copy link
Owner

guedes commented Jan 12, 2013

Nice, please fix the broken test "$ pgvm use 999" and create a new test to this issue.

Thanks!

@fike fike closed this Jan 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants