Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated for sagemaker endpoints compatibility #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated for sagemaker endpoints compatibility #21

wants to merge 3 commits into from

Conversation

AlejandroEsquivel
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel commented Aug 20, 2024 •
edited
Loading

Changed:

  • Update FastAPI code to include endpoints required by Sagemaker

Added:

  • Added serve file, and Dockerfile for custom Sagemaker images
  • Added CICD to publish to shared private repository

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review August 20, 2024 19:35
@AlejandroEsquivel AlejandroEsquivel marked this pull request as draft August 20, 2024 19:35
@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review August 22, 2024 23:52
CalebCourier
CalebCourier approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@CalebCourier CalebCourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @zsimjee any concerns with the changes to the app.py wrt our internal hosting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebCourier CalebCourier CalebCourier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlejandroEsquivel @CalebCourier