Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make on_fail validator an enum #583

Closed
wants to merge 11 commits into from
Closed

Make on_fail validator an enum #583

wants to merge 11 commits into from

Conversation

aaravnavani
Copy link
Contributor

This PR fixes this issue and creates an Enum for the on_fail validator. It then uses this Enum in the Validators base class.

ShreyaR
ShreyaR reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@ShreyaR ShreyaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix! Left a comment

guardrails/validator_base.py Outdated Show resolved Hide resolved
@aaravnavani aaravnavani marked this pull request as ready for review February 14, 2024 19:45
@aaravnavani
Copy link
Contributor Author

aaravnavani commented Feb 14, 2024 •
edited
Loading

@ShreyaR Sure, I just added all the on_fail actions that were listed on the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreyaR ShreyaR ShreyaR left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaravnavani @ShreyaR