-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input validation #483
Input validation #483
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
d50cc70
to
b437d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good! Can you please add a notebook to exemplify input validation scenarios?
if prompt_params is None: | ||
prompt_params = {} | ||
|
||
if msg_history: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long control switch. Can we split some of the logic up?
For ex:
def start_message_history_action
def validate_msg_history_schema
def start_prompt_action
def validate_prompt_schema
def start_instruction_action
def validate_instruction_schema
Implements input validation, as separate iterations in the logs. Still missing async tests, and some tests surrounding error raising are failing (pending discussion below).
A few last discussion points before this is ready:
EDIT
I've introduced
UserFacingException
, any exc wrapped in it will be propagated to the user.I've also added an
exception
field toOutputs
, so we don't just store it stringified