Validation Outcome #431
Merged
Validation Outcome #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install deps + pkg for nb runs * lock nb runner to 3.11.x * use cohere api key from environ * ref env vars for cohere + openai
* fix bad merge in code originally from validators.py * lint fixes
* use pypi pass from env * upgrade pip before installing deps * pass pypi pass explicitly * use environ competently
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage ? 81.33%
=======================================
Files ? 49
Lines ? 4537
Branches ? 0
=======================================
Hits ? 3690
Misses ? 847
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We'll need to update any wrappers we publish as well once we release this i.e. Langchain and I think Llama index? |
CalebCourier
added a commit
that referenced
this pull request
Nov 28, 2023
* start validation outcome changes * fix gather_reasks for non-structured output * lint fixes * more lint fixes * start test fixes, debug types * fix tests * fix types with overloads * fix tests * lint fixes * lint fixes * fix tests * lint fixes * switch to generics for ValidationOutcome * allow destructuring * remove None from generic type * init commit, changes to handle error in guard * handle error a layer deeper * update return in text2sql * remove extra fx in validation outcome * use error instead of exception * remove print statements plus lint * fix type * fix typing while maintaining type hinting * fix other type issues * autoformat * lint fixes * test fixes * autoformat * type fixes * lint fix * unused import * uncomment test parameters * merge/type fixes * guard: Allow calling parse with preconfigured num_reasks (#423) * Cron nb (#425) * install deps + pkg for nb runs * lock nb runner to 3.11.x * use cohere api key from environ * ref env vars for cohere + openai * fix bad merge in code originally from validators.py (#427) * fix bad merge in code originally from validators.py * lint fixes * bump version (#428) * update notebooks * Setup passed password (#429) * use pypi pass from env * upgrade pip before installing deps * pass pypi pass explicitly * use environ competently * list -> List * lint and test fixes * autoformat * lint and type fix * fix test * fix llm_output type * ' -> " * fix tests * lint fixes * fix notebooks again * fix docs * debug * validated_response -> validated_output --------- Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: rafael <[email protected]> Co-authored-by: zsimjee <[email protected]>
CalebCourier
added a commit
that referenced
this pull request
Dec 7, 2023
* start validation outcome changes * fix gather_reasks for non-structured output * lint fixes * more lint fixes * start test fixes, debug types * fix tests * fix types with overloads * fix tests * lint fixes * lint fixes * fix tests * lint fixes * switch to generics for ValidationOutcome * allow destructuring * remove None from generic type * init commit, changes to handle error in guard * handle error a layer deeper * update return in text2sql * remove extra fx in validation outcome * use error instead of exception * remove print statements plus lint * fix type * fix typing while maintaining type hinting * fix other type issues * autoformat * lint fixes * test fixes * autoformat * type fixes * lint fix * unused import * uncomment test parameters * merge/type fixes * guard: Allow calling parse with preconfigured num_reasks (#423) * Cron nb (#425) * install deps + pkg for nb runs * lock nb runner to 3.11.x * use cohere api key from environ * ref env vars for cohere + openai * fix bad merge in code originally from validators.py (#427) * fix bad merge in code originally from validators.py * lint fixes * bump version (#428) * update notebooks * Setup passed password (#429) * use pypi pass from env * upgrade pip before installing deps * pass pypi pass explicitly * use environ competently * list -> List * lint and test fixes * autoformat * lint and type fix * fix test * fix llm_output type * ' -> " * fix tests * lint fixes * fix notebooks again * fix docs * debug * validated_response -> validated_output --------- Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: rafael <[email protected]> Co-authored-by: zsimjee <[email protected]> impl and refactor autoformat and lint fixes lint fixes fix reask merging, harmonize Call and ValidationOutcome mark test as TODO force clean merge Validation Outcome (#431) * start validation outcome changes * fix gather_reasks for non-structured output * lint fixes * more lint fixes * start test fixes, debug types * fix tests * fix types with overloads * fix tests * lint fixes * lint fixes * fix tests * lint fixes * switch to generics for ValidationOutcome * allow destructuring * remove None from generic type * init commit, changes to handle error in guard * handle error a layer deeper * update return in text2sql * remove extra fx in validation outcome * use error instead of exception * remove print statements plus lint * fix type * fix typing while maintaining type hinting * fix other type issues * autoformat * lint fixes * test fixes * autoformat * type fixes * lint fix * unused import * uncomment test parameters * merge/type fixes * guard: Allow calling parse with preconfigured num_reasks (#423) * Cron nb (#425) * install deps + pkg for nb runs * lock nb runner to 3.11.x * use cohere api key from environ * ref env vars for cohere + openai * fix bad merge in code originally from validators.py (#427) * fix bad merge in code originally from validators.py * lint fixes * bump version (#428) * update notebooks * Setup passed password (#429) * use pypi pass from env * upgrade pip before installing deps * pass pypi pass explicitly * use environ competently * list -> List * lint and test fixes * autoformat * lint and type fix * fix test * fix llm_output type * ' -> " * fix tests * lint fixes * fix notebooks again * fix docs * debug * validated_response -> validated_output --------- Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: Nefertiti Rogers <[email protected]> Co-authored-by: rafael <[email protected]> Co-authored-by: zsimjee <[email protected]> many test fixes, many more to come
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
This PR contains a breaking change that consolidates all returnables from call and parse into a single class ValidationOutcome. It also adds a property onto this class for easy determination of whether validation succeeded or failed.
Addresses: #283