Make datetime separate datatype #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage ? 80.32%
=======================================
Files ? 34
Lines ? 3903
Branches ? 0
=======================================
Hits ? 3135
Misses ? 768
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonasferoz
force-pushed
the
extend-datetime-support
branch
from
1f10691 to
ca6fbb4
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
outdated, we're now only supporting datatypes available in JsonSchema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dateutil library is robust, capable of parsing a wide variety of datetime formats, including those with seconds and milliseconds (see ‘ISO format’ and ‘Hours with letters work’).
However, given that Python’s standard datetime library provides options to return an object as a date, time, or datetime, it might be useful to introduce a separate DateTime datatype that exclusively returns the datetime.datetime object. This allows the existing Date and Time classes to handle their respective strings while returning datetime.date and datetime.time objects.
In addition, each datatype can handle its own edge cases such as Unix epoch strings or ISO date weeks, both of which have a rudimentary implementation in this pull request.