Aspect to enforce unique app/region/stack on lambdas #2567
+172
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Introduce an
Aspect
to enforce unique combinations of app/region/stack onGuLambdaFunction
.A few projects at the Guardian seem to be mistakenly doing this, and when used in combination with a generated
riff-raff.yaml
can cause unexpected behaviour where only the last lambda defined will make it into the the deployments as the app/region/stack combination is used for the key.I ran into some circular dependency issues, so had to make some imports more specific in some other modules to resolve.