Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦋 Release package updates #2528

Merged
merged 2 commits into from
Dec 5, 2024
Merged

🦋 Release package updates #2528

merged 2 commits into from
Dec 5, 2024

Conversation

guardian-ci
Copy link
Contributor

@guardian-ci guardian-ci commented Dec 4, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@guardian/[email protected]

Major Changes

  • d3259e7: Support multiple usages of GuGithubActionsRole in a single AWS account

    This significantly changes the resources constructed by GuGithubActionsRole,
    specifically, the construct will no longer instantiate a GitHubOidcProvider.
    This is because you can only ever have one GitHubOidcProvider per provider
    domain (ie token.actions.githubusercontent.com) - while we may want multiple
    instances of GuGithubActionsRole in an AWS account, we can't have the
    GuGithubActionsRole construct trying to make a new GitHubOidcProvider with
    each instance.

    Consequently, you will need to instantiate the GitHubOidcProvider elsewhere
    as a singleton. At the Guardian, we do this with https://github.com/guardian/aws-account-setup.

Minor Changes

  • bf08a5e: Default to GP3 storage type for RDS

@github-actions github-actions bot force-pushed the changeset-release/main branch from 9d2a792 to 357996a Compare December 4, 2024 15:40
@github-actions github-actions bot force-pushed the changeset-release/main branch from 357996a to 6b63bd4 Compare December 5, 2024 17:25
@rtyley rtyley enabled auto-merge December 5, 2024 17:32
@rtyley rtyley merged commit 5f483a0 into main Dec 5, 2024
4 checks passed
@rtyley rtyley deleted the changeset-release/main branch December 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants