Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@guardian/[email protected]
Major Changes
d3259e7: Support multiple usages of
GuGithubActionsRole
in a single AWS accountThis significantly changes the resources constructed by
GuGithubActionsRole
,specifically, the construct will no longer instantiate a
GitHubOidcProvider
.This is because you can only ever have one
GitHubOidcProvider
per providerdomain (ie
token.actions.githubusercontent.com
) - while we may want multipleinstances of
GuGithubActionsRole
in an AWS account, we can't have theGuGithubActionsRole
construct trying to make a newGitHubOidcProvider
witheach instance.
Consequently, you will need to instantiate the
GitHubOidcProvider
elsewhereas a singleton. At the Guardian, we do this with https://github.com/guardian/aws-account-setup.
Minor Changes