Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use https://github.com/guardian/cdk/pull/2574 #629

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: Use https://github.com/guardian/cdk/pull/2574 #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cdk/lib/__snapshots__/cdk-playground.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ exports[`The Deploy stack matches the snapshot 1`] = `
"Metadata": {
"gu:cdk:constructs": [
"GuVpcParameter",
"GuSubnetListParameter",
"GuSubnetListParameter",
"GuVpcPublicSubnetsParameter",
"GuVpcPrivateSubnetsParameter",
"GuEc2AppExperimental",
"GuDistributionBucketParameter",
"GuCertificate",
Expand Down Expand Up @@ -110,14 +110,14 @@ exports[`The Deploy stack matches the snapshot 1`] = `
"Description": "Virtual Private Cloud to run EC2 instances within. Should NOT be the account default VPC.",
"Type": "AWS::SSM::Parameter::Value<AWS::EC2::VPC::Id>",
},
"cdkplaygroundPrivateSubnets": {
"VpcPrivateSubnets": {
"Default": "/account/vpc/primary/subnets/private",
"Description": "A list of private subnets",
"Description": "A comma-separated list of private subnets",
"Type": "AWS::SSM::Parameter::Value<List<AWS::EC2::Subnet::Id>>",
},
"cdkplaygroundPublicSubnets": {
"VpcPublicSubnets": {
"Default": "/account/vpc/primary/subnets/public",
"Description": "A list of public subnets",
"Description": "A comma-separated list of public subnets",
"Type": "AWS::SSM::Parameter::Value<List<AWS::EC2::Subnet::Id>>",
},
},
Expand Down Expand Up @@ -229,7 +229,7 @@ exports[`The Deploy stack matches the snapshot 1`] = `
},
],
"VPCZoneIdentifier": {
"Ref": "cdkplaygroundPrivateSubnets",
"Ref": "VpcPrivateSubnets",
},
},
"Type": "AWS::AutoScaling::AutoScalingGroup",
Expand Down Expand Up @@ -623,7 +623,7 @@ exports[`The Deploy stack matches the snapshot 1`] = `
},
],
"Subnets": {
"Ref": "cdkplaygroundPublicSubnets",
"Ref": "VpcPublicSubnets",
},
"Tags": [
{
Expand Down
5 changes: 2 additions & 3 deletions cdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions cdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,23 @@
"postbuild:event-forwarder": "cd dist && zip -r event-forwarder.zip ."
},
"devDependencies": {
"@guardian/cdk": "61.1.3",
"@aws-sdk/client-auto-scaling": "3.738.0",
"@aws-sdk/credential-providers": "3.738.0",
"@guardian/cdk": "github:guardian/cdk#aa/vpc",
"@guardian/eslint-config-typescript": "12.0.0",
"@guardian/prettier": "8.0.1",
"@types/aws-lambda": "8.10.147",
"@types/jest": "^29.5.14",
"@types/node": "22.12.0",
"aws-cdk": "2.177.0",
"aws-cdk-lib": "2.177.0",
"constructs": "10.4.2",
"esbuild": "0.24.2",
"jest": "^29.7.0",
"source-map-support": "^0.5.20",
"ts-jest": "29.2.5",
"ts-node": "^10.9.2",
"typescript": "5.5.4",
"@types/aws-lambda": "8.10.147",
"@aws-sdk/client-auto-scaling": "3.738.0",
"@aws-sdk/credential-providers": "3.738.0",
"esbuild": "0.24.2"
"typescript": "5.5.4"
},
"prettier": "@guardian/prettier",
"jest": {
Expand Down