-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured Logging #595
Merged
Merged
Structured Logging #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e8feb8
to
83b05bb
Compare
83b05bb
to
9e1eb06
Compare
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
sdroege
reviewed
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice otherwise
mbiggio
reviewed
Mar 10, 2022
mbiggio
reviewed
Mar 10, 2022
ed5c83e
to
690811c
Compare
Avoids bringing the fmt::Write trait into scope.
e2ccc37
to
50cc473
Compare
Merged
sdroege
approved these changes
Mar 11, 2022
mbiggio
pushed a commit
to mbiggio/gtk-rs-core
that referenced
this pull request
Mar 14, 2022
Structured Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bindings for these functions:
glib::log_set_writer_func
glib::log_structured_array
GStr
wrapper for a borrowedGString
, so we can avoid copying the log keys.glib::log_variant
glib::log_writer_default
glib::log_writer_format_fields
glib::log_writer_journald
glib::log_writer_standard_streams
glib::log_writer_is_journald
- unix onlyglib::log_writer_supports_color
- unix onlyglib::log_writer_default_set_use_stderr
glib::log_writer_default_would_drop
And some new macros:
glib::gstr
- Turns a string literal into a&'static GStr
, by appending a nul byte at compile timeglib::log_structured
- The main interface. From the docs: