codegen: Use GString::as_str instead of Option<GString>::as_deref #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2022
sdroege
approved these changes
Mar 13, 2022
heftig
added a commit
to heftig/gir
that referenced
this pull request
Mar 30, 2022
We can't call `as_str` on `Option<GString>`. Pre-gtk-rs#1327, we used `as_deref` to make use of `GString`'s deref-to-`&str`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for gtk-rs/gtk-rs-core#600, but doesn't depend on it (this PR shouldn't break anything)