All Announcements View #175
Merged
+391
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulon12
force-pushed
the
rahul/all_announcements
branch
from
7084325 to
2a1c592
Compare
azooz2003-bit
approved these changes
Jan 19, 2025
CanvasPlusPlayground/Common/Network/API Requests/GetAnnouncementsBatchRequest.swift
Outdated
Show resolved
Hide resolved
CanvasPlusPlayground/Common/Network/API Requests/GetAnnouncementsBatchRequest.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+14
| replacingOccurrences(of: "<[^>]+>", with: "", options: .regularExpression) | ||
| .replacingOccurrences(of: " ", with: "") | ||
| .replacingOccurrences(of: "&", with: "&") |
There was a problem hiding this comment.
Fixes issue where announcements may show HTML entities (like  ).
Comment on lines
39
to
48
| guard announcement.course == nil, | ||
| let contextCode = announcement.contextCode else { | ||
| return announcement | ||
| } | ||
|
|
||
| announcement.course = courses.first(where: { course in | ||
| contextCode.contains(course.id) | ||
| }) | ||
|
|
||
| return announcement |
|
@azooz2003-bit Can you take one more look? I've updated the PR |
sure, can you rebase w main again. i wanna make sure theres no more dup key errors. |
nvm, code looks good. u can merge. ill try after u merge |
|
@azooz2003-bit try now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes --
Changes Made
contextCodes.Sidebar.swift)Screenshots (if applicable)