This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
This should work #13
Open
This should work #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the procedure for the commandline, it should now be able to do more complex tasks (future?) and should be easier to use as a module Added .gitattributes, should fix all the lineEnding stuff.
Recoded the existsing groove.py to be more like a library. The library contains everything you should need to get started. The old wget download method has been booted in favor of an integrated python downloader that supports callBacks on every blocks downloaded (mainly for status updates to the user) The functions has been rewritten to reuse as much code as possible, while still keeping them simple. Everything is the library is kept public, as the script still gets banned, and the user might want to code his own procedure to download. Cookies (session ID's) are now saved on exit, and reused if they are not expired, possibly making grooveshark happier. (this add a new dependency, cookielib, should be included with python) QueueID's are now generated correctly I'm using urlgrabber.keepalive to support HTTP/1.1 and keep-alive, this is not included in the newer versions, so it requires an old version of urlgrabber. All prints have been removed, that is now left to the end user.
That was some strange stuff that happened there, it's fixed now
Should now better emulate groovesharks browser player Added automatic country getting, maybe grooveshark logs it? Added downlading of crossdomains.xml, maybe it's used? they get it on tinysong.com, so i did it just to be sure.
Fixed the example Edited the class name to grooveshark, it now looks better
I removed the few prints that were left in the library Added a timeout for the token, it's only valid for 25 minutes on the grooveshark servers (according to the jsQueue sourcecode)
The library can now be corretly imported (i didn't realize the python file HAD to be called __init__.py it's named that now Remove the final 2 prints from the code Added a timeout for the token, it only works 25 minutes according to the sourcecode. The library now acknowledges this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a lot of stuff:
.gitattributes
a library to use in other applications
The library should emulate groovesharks browser player near perfect, i hope i don't get banned, if i do i don't know what i need. It proved access to all the functions, but includes a easy to use download method that supports callbacks.
I hope everyone enjoys.