grails#13552 Correct bom

* fix grails-async * fix grails-events * fix converters * fix testing support split * remove spotbugs from bom * add rxjava1, 2, 3 to bom (spring includes 3)
gsartori · Jan 16, 2025 · d11d0aa · d11d0aa
1 parent 9e9c486
commit d11d0aa
Show file tree

Hide file tree

Showing 17 changed files with 25 additions and 33 deletions.
diff --git a/build.gradle b/build.gradle
@@ -405,7 +405,7 @@ subprojects { subproject ->
         testImplementation "org.junit.platform:junit-platform-runner"
         testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
 
-        compileOnly "com.github.spotbugs:spotbugs-annotations"
+        //compileOnly "com.github.spotbugs:spotbugs-annotations"
 
         if (subproject.name != "grails-docs") {
             // Logging

diff --git a/dependabot/build.gradle b/dependabot/build.gradle
@@ -12,7 +12,6 @@ dependencies {
     api "net.bytebuddy:byte-buddy:${project['byte-buddy.version']}"
     api "commons-codec:commons-codec:${project['commons-codec.version']}"
     api "org.apache.commons:commons-text:${project['commons-text.version']}"
-    api "org.grails.plugins:converters:${project['converters.version']}"
     api "io.methvin:directory-watcher:${project['directory-watcher.version']}"
     api "org.xhtmlrenderer:flying-saucer-pdf-openpdf:${project['flying-saucer-pdf-openpdf.version']}"
     api "org.webjars.npm:bootstrap:${project['bootstrap.version']}"
@@ -34,7 +33,6 @@ dependencies {
     api "org.grails:grails-gdoc-engine:${project['grails-gdoc-engine.version']}"
     api "org.grails:grails-gradle-plugin:${project['grails-gradle-plugin.version']}"
     api "org.grails:grails-gorm-testing-support:${project['grails-testing-support.version']}"
-    api "org.grails:grails-testing-support:${project['grails-testing-support.version']}"
     api "org.grails:grails-web-testing-support:${project['grails-testing-support.version']}"
     api "org.apache.groovy:groovy-bom:${project['groovy.version']}"
     api "org.grails:grails-gsp:${project['gsp.version']}"
@@ -78,7 +76,6 @@ dependencies {
     api "org.grails.profiles:web:${project['profiles-web.version']}"
     api "org.spockframework:spock-core:${project['spock.version']}"
     api "org.spockframework:spock-spring:${project['spock.version']}"
-    api "com.github.spotbugs:spotbugs-annotations:${project['spotbugs-annotations.version']}"
     api "org.springframework.boot:spring-boot-cli:${project['spring-boot.version']}"
     api "org.springframework.boot:spring-boot-gradle-plugin:${project['spring-boot.version']}"
     api "org.springframework:springloaded:${project['springloaded.version']}"

diff --git a/gradle.properties b/gradle.properties
@@ -15,9 +15,6 @@ plexusComponentApiVersion=1.0-alpha-33
 plexusSecDispatcherVersion=1.4
 plexusSisuInjectVersion=2.6.0
 slf4jVersion=2.0.16
-rxJava1Version=1.3.8
-rxJava2Version=2.2.21
-rxJava3Version=3.1.10
 gparsVersion=1.2.1
 
 org.gradle.caching=true
@@ -33,8 +30,8 @@ preventSnapshotPublish=false
 # https://github.com/grails/grails-gradle-plugin/issues/222
 slf4jPreventExclusion=true
 
-# Generated on Tue Jan 07 15:14:48 EST 2025 by: ./gradlew :grails-bom:syncProps
-# Only version value modifications allowed after this point. Do not insert or change version names.
+# Generated on Thu Jan 16 10:23:54 EST 2025 by: ./gradlew :grails-bom:syncProps
+# Only version value modifications allowed after this point. Do not insert or change version names. 
 ant.version=1.10.15
 asciidoctorj.version=3.0.0
 asset-pipeline-gradle.version=5.0.5
@@ -44,7 +41,6 @@ bootstrap-icons.version=1.11.3
 byte-buddy.version=1.15.5
 commons-codec.version=1.17.1
 commons-text.version=1.12.0
-converters.version=6.0.0-SNAPSHOT
 directory-watcher.version=0.18.0
 flying-saucer-pdf-openpdf.version=9.4.0
 geb-spock.version=7.0
@@ -53,7 +49,6 @@ grails-datastore-gorm-hibernate5.version=9.0.0-SNAPSHOT
 grails-datastore-gorm-mongodb.version=9.0.0-SNAPSHOT
 grails-gdoc-engine.version=1.0.1
 grails-gradle-plugin.version=7.0.0-SNAPSHOT
-grails-testing-support.version=4.0.0-SNAPSHOT
 groovy.version=4.0.24
 gsp.version=7.0.0-SNAPSHOT
 h2.version=2.3.232
@@ -73,8 +68,6 @@ plugins-geb.version=5.0.0-SNAPSHOT
 plugins-hibernate5.version=9.0.0-SNAPSHOT
 plugins-mongodb.version=9.0.0-SNAPSHOT
 plugins-neo4j.version=8.1.0
-plugins-rxjava.version=1.1.1
-plugins-rxjava2.version=2.0.0
 plugins-scaffolding.version=6.0.0-SNAPSHOT
 plugins-views-gradle.version=4.0.0-SNAPSHOT
 plugins-views-json.version=4.0.0-SNAPSHOT
@@ -90,8 +83,10 @@ profiles-rest-api-plugin.version=7.0.1
 profiles-vue.version=7.0.1
 profiles-web.version=7.0.1
 profiles-web-plugin.version=7.0.1
+rxjava.version=1.3.8
+rxjava2.version=2.2.21
+rxjava3.version=3.1.10
 spock.version=2.3-groovy-4.0
-spotbugs-annotations.version=4.8.6
 spring-boot.version=3.4.1
 springloaded.version=1.2.8.RELEASE
 views-json-testing-support.version=4.0.0-SNAPSHOT
diff --git a/grails-async/rxjava/build.gradle b/grails-async/rxjava/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-async-core')
-    api "io.reactivex:rxjava:$rxJava1Version"
+    api "io.reactivex:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-async/rxjava2/build.gradle b/grails-async/rxjava2/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-async-core')
-    api "io.reactivex.rxjava2:rxjava:$rxJava2Version"
+    api "io.reactivex.rxjava2:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-async/rxjava3/build.gradle b/grails-async/rxjava3/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-async-core')
-    api "io.reactivex.rxjava3:rxjava:$rxJava3Version"
+    api "io.reactivex.rxjava3:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-bom/build.gradle b/grails-bom/build.gradle
@@ -31,25 +31,25 @@ ext {
         com.h2database:h2::
         commons-codec:commons-codec::
         io.methvin:directory-watcher::
+        io.reactivex:rxjava:::rxjava
+        io.reactivex.rxjava2:rxjava:::rxjava2
+        io.reactivex.rxjava3:rxjava:::rxjava3
         jline:jline::
         net.bytebuddy:byte-buddy::
         net.java.dev.jna:jna::
         org.apache.ant:ant:,junit:
         org.apache.commons:commons-text::
-        org.apache.groovy:groovy:bom:$groovyVersion
+        org.apache.groovy:groovy:bom:::
         org.asciidoctor:asciidoctorj::
         org.fusesource.jansi:jansi::
         org.gebish:geb-spock::
-        com.github.spotbugs:spotbugs-annotations::
-        org.grails.plugins:converters::
         org.grails.plugins:gsp::
         org.grails:grails-datastore-gorm-hibernate5::
         org.grails:grails-datastore-gorm-mongodb::
-        org.grails:grails-datastore:async,core,gorm,gorm-async,gorm-support,gorm-rx,gorm-test,gorm-validation,web,gorm-tck:
+        org.grails:grails-datastore-async,grails-datastore-core,grails-datastore-gorm,grails-datastore-gorm-async,grails-datastore-gorm-support,grails-datastore-gorm-rx,grails-datastore-gorm-test,grails-datastore-gorm-validation,grails-datastore-web,grails-datastore-gorm-tck,grails-gorm-testing-support:::grails-datastore
         org.grails:grails-gdoc-engine::
         org.grails:grails-gradle-plugin::
-        org.grails:grails-testing-support,grails-gorm-testing-support,grails-web-testing-support::
-        org.grails:grails:gsp,web-gsp,web-taglib::gsp
+        org.grails:grails:gsp,web-gsp,web-taglib,web-testing-support::gsp
         org.grails:views-json-testing-support::
         org.jsoup:jsoup::
         org.mongodb:bson:,record-codec::mongodb

diff --git a/grails-bom/plugins.properties b/grails-bom/plugins.properties
@@ -6,8 +6,6 @@ hibernate5=9.0.0-SNAPSHOT
 mongodb=9.0.0-SNAPSHOT
 views-json-templates=9.0.0-SNAPSHOT
 neo4j=8.1.0
-rxjava=1.1.1
-rxjava2=2.0.0
 scaffolding=6.0.0-SNAPSHOT
 views-gradle=4.0.0-SNAPSHOT
 views-json=4.0.0-SNAPSHOT

diff --git a/grails-core/build.gradle b/grails-core/build.gradle
@@ -18,6 +18,8 @@ dependencies {
     api project(":grails-bootstrap")
     api project(":grails-spring")
 
+    // This only needs the datastore version property because of how source jars are being created.
+    // Build will succeed, but assemble will fail without this because of task ordering in gradle.
     api "org.grails:grails-datastore-core:${project['grails-datastore.version']}"
 
     testImplementation "org.springframework:spring-jdbc"

diff --git a/grails-events/rxjava/build.gradle b/grails-events/rxjava/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-events-core')
-    api "io.reactivex:rxjava:$rxJava1Version"
+    api "io.reactivex:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-events/rxjava2/build.gradle b/grails-events/rxjava2/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-events-core')
-    api "io.reactivex.rxjava2:rxjava:$rxJava2Version"
+    api "io.reactivex.rxjava2:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-events/rxjava3/build.gradle b/grails-events/rxjava3/build.gradle
@@ -2,7 +2,7 @@ dependencies {
     implementation platform(project(':grails-bom'))
 
     api project(':grails-events-core')
-    api "io.reactivex.rxjava3:rxjava:$rxJava3Version"
+    api "io.reactivex.rxjava3:rxjava"
 
     implementation 'org.apache.groovy:groovy'
     implementation 'org.slf4j:slf4j-api'

diff --git a/grails-plugin-rest/build.gradle b/grails-plugin-rest/build.gradle
@@ -6,7 +6,7 @@ dependencies {
             project(":grails-plugin-controllers"),
             project(":grails-plugin-datasource")
 
-    api "org.grails.plugins:converters"
+    api project(":grails-plugin-converters")
 
     implementation "com.github.ben-manes.caffeine:caffeine"
     testImplementation project(":grails-plugin-url-mappings"),

diff --git a/grails-test-suite-base/build.gradle b/grails-test-suite-base/build.gradle
@@ -6,5 +6,5 @@ dependencies {
         project(':grails-test'),
         project(':grails-plugin-domain-class')
 
-    api "org.grails.plugins:converters"
+    api project(":grails-plugin-converters")
 }
diff --git a/grails-test-suite-web/build.gradle b/grails-test-suite-web/build.gradle
@@ -25,7 +25,7 @@ dependencies {
                 project(':grails-web-databinding'),
                 project(':grails-spring')
 
-    testImplementation "org.grails.plugins:converters"
+    testImplementation project(":grails-plugin-converters")
     testImplementation "org.grails:grails-datastore-gorm-hibernate5"
     testImplementation "org.grails:grails-web-testing-support"
     testImplementation "org.grails.plugins:gsp"

diff --git a/grails-test/build.gradle b/grails-test/build.gradle
@@ -12,7 +12,7 @@ dependencies {
 
     api project(":grails-plugin-mimetypes")
     api project(":grails-web")
-    api "org.grails.plugins:converters"
+    api project(":grails-plugin-converters")
 
     // command line requirements
     api  "jline:jline"

diff --git a/grails-web-common/build.gradle b/grails-web-common/build.gradle
@@ -13,5 +13,5 @@ dependencies {
     api "org.springframework:spring-webmvc"
     api "org.springframework:spring-context-support"
     implementation "com.github.ben-manes.caffeine:caffeine"
-    compileOnly "com.github.spotbugs:spotbugs-annotations"
+    //compileOnly "com.github.spotbugs:spotbugs-annotations"
 }