Sql to weka #13
Merged
Sql to weka #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new RuntimeException("SQL failed to fetch data"); | ||
| } | ||
| return dataset; | ||
| } |
There was a problem hiding this comment.
Behemoth function - way too big. Can you refactor into smaller functions with functional names so I know exactly what is going on?
There was a problem hiding this comment.
Fair point, I'll sepaerate sql stuff and sql to instaces stuff
|
don't merge yet, need to add timeslicing to the data table. I'll edit the databasewiki to describe it. |
Also some refactoring and tests done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeecb what's your take on the design of the code?
@tlfrd Any comments on database design?
Referencing #7 and #11