GAIA-26824 Remove the get_access_token from sdk and --print_token from cli #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal/Problem:
With auth0, we no longer allow people to specify username and password to get their access token.
So
get_access_token
function, that allows people to use their username and password to fetch their access token needs to be removed.We can see no calls to
/api-token
from non webapp origin with username and passwd for last 4 days. Kibana.Solution.
Remove the
get_access_token
function from sdk and --print_token argument from cli.Testing
Tested importing
get_access_token
:from groclient.lib import get_access_token
throws an error as expected.Tested gro_client: