Fixing Grist's API console #1373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Hello @berhalak,
Could you give more details on how you reproduce the issue? On the SAAS instance apiconsole, I don't have either a JS error or an error popup like you share on your screenshot
You need to load a console from a running document, for example: |
Co-authored-by: Florent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixing Grist's API console JavaScript error caused by recent addition of new
scimendpoint documentation.Proposed solution
Fix is simple, script that copies shared parameters across multiple endpoints just ignores external endpoints. Currently Grist doesn't share any parameters with
scimendpoints so this solution is good enough.Related issues
Additionally there is a fix to
scimendpoints, that externalize endpoint parameters. It is not needed now (as no parameters are shared), but might be needed in future.gristlabs/grist-help#467
Has this been tested?
manually only
Screenshots / Screencasts