Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular to v19 & other dependencies to latest compatible #1173

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 7 additions & 9 deletions client/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@
"prefix": "cvc",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"builder": "@angular-devkit/build-angular:application",
"options": {
"outputPath": "../server/public",
"outputPath": {
"base": "../server/public"
},
"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"polyfills": ["src/polyfills.ts"],
"tsConfig": "tsconfig.app.json",
"assets": [
"src/favicon.ico",
Expand All @@ -47,12 +48,11 @@
"includePaths": ["src/themes/", "node_modules"]
},
"scripts": [],
"vendorChunk": true,
"extractLicenses": false,
"buildOptimizer": false,
"sourceMap": true,
"optimization": false,
"namedChunks": true
"namedChunks": true,
"browser": "src/main.ts"
},
"configurations": {
"production": {
Expand All @@ -78,8 +78,6 @@
"sourceMap": false,
"namedChunks": false,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
Expand Down
50 changes: 25 additions & 25 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,48 +23,48 @@
"error-stack-parser": "2.0.6"
},
"dependencies": {
"@angular-devkit/schematics": "18.1.2",
"@angular/animations": "^18.1.2",
"@angular/common": "^18.1.2",
"@angular/compiler": "^18.1.2",
"@angular/core": "^18.1.2",
"@angular/forms": "^18.1.2",
"@angular/platform-browser": "^18.1.2",
"@angular/platform-browser-dynamic": "^18.1.2",
"@angular/router": "^18.1.2",
"@apollo/client": "^3.11.1",
"@angular-devkit/schematics": "19.0.7",
"@angular/animations": "^19.0.6",
"@angular/common": "^19.0.6",
"@angular/compiler": "^19.0.6",
"@angular/core": "^19.0.6",
"@angular/forms": "^19.0.6",
"@angular/platform-browser": "^19.0.6",
"@angular/platform-browser-dynamic": "^19.0.6",
"@angular/router": "^19.0.6",
"@apollo/client": "^3.12.6",
"@ngneat/until-destroy": "^10.0.0",
"@ngrx/component": "^18.0.1",
"@ngx-formly/core": "^6.3.6",
"@ngx-formly/ng-zorro-antd": "^6.3.6",
"apollo-angular": "^7.0.2",
"ng-zorro-antd": "18.0.1",
"@ngrx/component": "^19.0.0",
"@ngx-formly/core": "^6.3.12",
"@ngx-formly/ng-zorro-antd": "^6.3.12",
"apollo-angular": "^8.0.0",
"ng-zorro-antd": "19.0.1",
"ngx-cookie-service": "^18.0.0",
"ngx-ui-scroll": "3.2.0",
"rxjs": "^7.8.1",
"rxjs-etc": "^10.6.2",
"rxjs-spy": "^8.0.2",
"ts-enum-util": "^4.0.2",
"ts-mixin-extended": "^1.1.1",
"vscroll": "1.6.1",
"ngx-ui-scroll": "3.2.0",
"zone.js": "0.14.3"
"zone.js": "0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^18.1.2",
"@angular-devkit/core": "^18.1.2",
"@angular-devkit/build-angular": "^19.0.7",
"@angular-devkit/core": "^19.0.7",
"@angular-eslint/schematics": "^18.1.0",
"@angular/cli": "^18.1.2",
"@angular/compiler-cli": "18.1.2",
"@angular/cli": "^19.0.7",
"@angular/compiler-cli": "19.0.6",
"@graphql-codegen/add": "^5.0.3",
"@graphql-codegen/cli": "^5.0.2",
"@graphql-codegen/cli": "^5.0.3",
"@graphql-codegen/fragment-matcher": "^5.0.2",
"@graphql-codegen/introspection": "^4.0.3",
"@graphql-codegen/typescript": "^4.0.9",
"@graphql-codegen/typescript": "^4.1.2",
"@graphql-codegen/typescript-apollo-angular": "^4.0.0",
"@graphql-codegen/typescript-apollo-client-helpers": "^3.0.0",
"@graphql-codegen/typescript-operations": "^4.2.3",
"@graphql-codegen/typescript-operations": "^4.4.0",
"@parcel/watcher": "^2.4.1",
"@types/node": "^20.14.12",
"@types/node": "^22.10.6",
"@typescript-eslint/utils": "^7.17.0",
"directory-tree": "^3.5.1",
"eslint": "^8.56.0",
Expand Down
6 changes: 5 additions & 1 deletion client/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@ declare let gtag: Function
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.less'],
standalone: false,
})
export class AppComponent {
constructor(private iconService: NzIconService, private router: Router) {
constructor(
private iconService: NzIconService,
private router: Router
) {
this.addIcons(fullColorIcons)
if (environment.production) {
this.router.events.subscribe((event) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export const FEED_SCROLL_SERVICE_TOKEN =
templateUrl: './activity-feed.component.html',
styleUrl: './activity-feed.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
CommonModule,
UiScrollModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { CommonModule } from '@angular/common'

@Component({
selector: 'cvc-activity-feed-counts',
standalone: true,
imports: [CommonModule, NzTypographyModule],
templateUrl: './feed-counts.component.html',
styleUrl: './feed-counts.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
UserFilterSearchQuery,
UserFilterSearchQueryVariables,
} from '@app/generated/civic.apollo'
import { CommonModule, KeyValuePipe } from '@angular/common'
import { CommonModule } from '@angular/common'
import { FormsModule } from '@angular/forms'
import { NzFormModule } from 'ng-zorro-antd/form'
import { NzSelectModule } from 'ng-zorro-antd/select'
Expand Down Expand Up @@ -62,11 +62,9 @@ export const defaultFilters = {}
@UntilDestroy()
@Component({
selector: 'cvc-activity-feed-filters',
standalone: true,
imports: [
CommonModule,
FormsModule,
KeyValuePipe,
NzAlertModule,
NzButtonModule,
NzIconModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { toSignal } from '@angular/core/rxjs-interop'

@Component({
selector: 'cvc-org-filter-select',
standalone: true,
imports: [
CommonModule,
FormsModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import { toSignal } from '@angular/core/rxjs-interop'

@Component({
selector: 'cvc-user-filter-select',
standalone: true,
imports: [
CommonModule,
FormsModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { CvcActivityRevision } from '../shared/activity-revision/activity-revisi

@Component({
selector: 'cvc-accept-revisions-activity-details',
standalone: true,
imports: [CommonModule, CvcActivityRevision],
templateUrl: './accept-revisions-activity.component.html',
styleUrl: './accept-revisions-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-comment-activity-details',
standalone: true,
imports: [CommonModule, CvcCommentBodyModule, NzTypographyModule],
templateUrl: './comment-activity.component.html',
styleUrl: './comment-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { CommonModule } from '@angular/common'

@Component({
selector: 'cvc-create-mp-activity-details',
standalone: true,
imports: [CommonModule],
templateUrl: './create-mp-activity.component.html',
styleUrl: './create-mp-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { JsonPipe } from '@angular/common'

@Component({
selector: 'cvc-create-variant-activity-details',
standalone: true,
imports: [JsonPipe],
templateUrl: './create-variant-activity.component.html',
styleUrl: './create-variant-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-delete-comment-activity-details',
standalone: true,
imports: [CommonModule, CvcCommentBodyModule, NzTypographyModule],
templateUrl: './delete-comment-activity.component.html',
styleUrl: './delete-comment-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { DeprecateFeatureActivityDetailFragment } from '@app/generated/civic.apo

@Component({
selector: 'cvc-deprecate-feature-activity-details',
standalone: true,
imports: [],
templateUrl: './deprecate-feature-activity.component.html',
styleUrl: './deprecate-feature-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-deprecate-mp-activity-details',
standalone: true,
imports: [CvcCommentBodyModule, NzTypographyModule],
templateUrl: './deprecate-mp-activity.component.html',
styleUrl: './deprecate-mp-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { ChangeDetectionStrategy, Component, input } from '@angular/core'
import { DeprecateVariantActivityDetailFragment } from '@app/generated/civic.apollo'
import { JsonPipe } from '@angular/common'

@Component({
selector: 'cvc-deprecate-variant-activity-details',
standalone: true,
imports: [JsonPipe],
templateUrl: './deprecate-variant-activity.component.html',
styleUrl: './deprecate-variant-activity.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ import { CvcDeleteCommentActivity } from './delete-comment/delete-comment-activi

@Component({
selector: 'cvc-activity-feed-item-details',
standalone: true,
imports: [
CommonModule,
CvcPipesModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-flag-entity-activity-details',
standalone: true,
imports: [CommonModule, CvcCommentBodyModule, NzTypographyModule],
templateUrl: './flag-entity-activity.component.html',
styleUrl: './flag-entity-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { JsonPipe } from '@angular/common'

@Component({
selector: 'cvc-moderate-assertion-activity-details',
standalone: true,
imports: [JsonPipe],
templateUrl: './moderate-assertion-activity.component.html',
styleUrl: './moderate-assertion-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { JsonPipe } from '@angular/common'

@Component({
selector: 'cvc-moderate-evidence-activity-details',
standalone: true,
imports: [JsonPipe],
templateUrl: './moderate-evidence-activity.component.html',
styleUrl: './moderate-evidence-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ import {
RejectRevisionsActivityDetailFragment,
Revision,
} from '@app/generated/civic.apollo'
import { JsonPipe } from '@angular/common'
import { CvcActivityRevision } from '../shared/activity-revision/activity-revision.component'

@Component({
selector: 'cvc-reject-revisions-activity-details',
standalone: true,
imports: [JsonPipe, CvcActivityRevision],
imports: [CvcActivityRevision],
templateUrl: './reject-revisions-activity.component.html',
styleUrl: './reject-revisions-activity.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-resolve-flag-activity-details',
standalone: true,
imports: [CvcCommentBodyModule, NzTypographyModule],
templateUrl: './resolve-flag-activity.component.html',
styleUrl: './resolve-flag-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CommonModule, JsonPipe } from '@angular/common'
import { CommonModule } from '@angular/common'
import {
ChangeDetectionStrategy,
Component,
Expand Down Expand Up @@ -36,11 +36,9 @@ type ColumnDefinition = {

@Component({
selector: 'cvc-activity-revision',
standalone: true,
imports: [
CommonModule,
FormsModule,
JsonPipe,
NzTypographyModule,
NzSwitchModule,
NzGridModule,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-submit-assertion-activity-details',
standalone: true,
imports: [CvcCommentBodyModule, NzTypographyModule],
templateUrl: './submit-assertion-activity.component.html',
styleUrl: './submit-assertion-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { NzTypographyModule } from 'ng-zorro-antd/typography'

@Component({
selector: 'cvc-submit-evidence-activity-details',
standalone: true,
imports: [CvcCommentBodyModule, NzTypographyModule],
templateUrl: './submit-evidence-activity.component.html',
styleUrl: './submit-evidence-activity.component.less',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ import {
Revision,
SuggestRevisionSetActivityDetailFragment,
} from '@app/generated/civic.apollo'
import { JsonPipe } from '@angular/common'
import { CvcActivityRevision } from '../shared/activity-revision/activity-revision.component'

@Component({
selector: 'cvc-suggest-revision-set-activity-details',
standalone: true,
imports: [JsonPipe, CvcActivityRevision],
imports: [CvcActivityRevision],
templateUrl: './suggest-revisions-activity.component.html',
styleUrl: './suggest-revisions-activity.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import { ChangeDetectionStrategy, Component, input } from '@angular/core'
import { SuggestSourceActivityDetailFragment } from '@app/generated/civic.apollo'
import { JsonPipe } from '@angular/common'
import { NzDescriptionsModule } from 'ng-zorro-antd/descriptions'
import { NzTagModule } from 'ng-zorro-antd/tag'
import { CvcEmptyValueModule } from '@app/forms/components/empty-value/empty-value.module'

@Component({
selector: 'cvc-suggest-source-activity-details',
standalone: true,
imports: [JsonPipe, NzDescriptionsModule, NzTagModule, CvcEmptyValueModule],
imports: [NzDescriptionsModule, NzTagModule, CvcEmptyValueModule],
templateUrl: './suggest-source-activity.component.html',
styleUrl: './suggest-source-activity.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import { ChangeDetectionStrategy, Component, input } from '@angular/core'
import { UpdateSourceSuggestionStatusActivityDetailFragment } from '@app/generated/civic.apollo'
import { JsonPipe } from '@angular/common'
import { CvcEmptyValueModule } from '@app/forms/components/empty-value/empty-value.module'
import { NzDescriptionsModule } from 'ng-zorro-antd/descriptions'
import { NzTagModule } from 'ng-zorro-antd/tag'

@Component({
selector: 'cvc-update-source-suggestion-activity-details',
standalone: true,
imports: [JsonPipe, NzDescriptionsModule, NzTagModule, CvcEmptyValueModule],
imports: [NzDescriptionsModule, NzTagModule, CvcEmptyValueModule],
templateUrl: './update-source-suggestion-activity.component.html',
styleUrl: './update-source-suggestion-activity.component.less',
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down
Loading
Loading