GSYE-835: Adapt TankEnergyParameters.get_min_energy_consumption so th…

[hannesdiedrich]

…e storage temperature can drop to its mininum

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (197ad2e) to head (c8445be).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
- Coverage   69.68%   69.62%   -0.06%     
==========================================
  Files         150      150              
  Lines       14258    14264       +6     
  Branches     2672     2672              
==========================================
- Hits         9935     9932       -3     
- Misses       3798     3808      +10     
+ Partials      525      524       -1     

[spyrostz]

LGTM, however this does not handle the unmatched heatpump demand if I recall this feature correctly. Frankly I was never too much of a fan of this feature and I do not mind skipping its implementation, just asking to have the full picture here.

[hannesdiedrich]

LGTM, however this does not handle the unmatched heatpump demand if I recall this feature correctly. Frankly I was never too much of a fan of this feature and I do not mind skipping its implementation, just asking to have the full picture here.

AFAIS, the implementation of the unmatched demand is not influenced by this change.

gsy-e/src/gsy_e/models/strategy/energy_parameters/heatpump/tank.py

Line 89 in b9f5e65

def get_unmatched_demand_kWh(self, time_slot: DateTime) -> float:

It depends on the get_temp_increase_K which in turn depends on the traded energy.

In this PR we only change the value of the bid energy, so before trading.

[spyrostz]

LGTM, however this does not handle the unmatched heatpump demand if I recall this feature correctly. Frankly I was never too much of a fan of this feature and I do not mind skipping its implementation, just asking to have the full picture here.

AFAIS, the implementation of the unmatched demand is not influenced by this change.

gsy-e/src/gsy_e/models/strategy/energy_parameters/heatpump/tank.py

Line 89 in b9f5e65

def get_unmatched_demand_kWh(self, time_slot: DateTime) -> float:

It depends on the get_temp_increase_K which in turn depends on the traded energy.
In this PR we only change the value of the bid energy, so before trading.

Got it and thanks for the clarification!