GSYE-837: Fixed scm_cn_hours_of_delay dict key, in order to expect th… #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e key that gsy-web sends to gsy-e.
| @@ -248,7 +248,7 @@ def _create_config_settings_object( | |||
| "external_connection_enabled": settings.get("external_connection_enabled", False), | |||
| "aggregator_device_mapping": aggregator_device_mapping, | |||
| "hours_of_delay": settings.get("scm", {}).get( | |||
| "hours_of_delay", ConstSettings.SCMSettings.HOURS_OF_DELAY | |||
| "scm_cn_hours_of_delay", ConstSettings.SCMSettings.HOURS_OF_DELAY | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1822 +/- ##
==========================================
+ Coverage 69.56% 69.61% +0.04%
==========================================
Files 150 150
Lines 14228 14227 -1
Branches 2667 2666 -1
==========================================
+ Hits 9898 9904 +6
+ Misses 3801 3794 -7
Partials 529 529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e key that gsy-web sends to gsy-e.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master