Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-650: Fix OrderUpdater order rate progression #1732

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

hannesdiedrich
Copy link
Member

@hannesdiedrich hannesdiedrich commented Jan 9, 2024

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spyrostz
spyrostz previously approved these changes Jan 19, 2024
Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c54ab4) 68.82% compared to head (4c9cb08) 68.85%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
+ Coverage   68.82%   68.85%   +0.02%     
==========================================
  Files         145      145              
  Lines       13599    13597       -2     
  Branches     2021     2020       -1     
==========================================
+ Hits         9360     9362       +2     
+ Misses       3728     3726       -2     
+ Partials      511      509       -2     

@hannesdiedrich hannesdiedrich merged commit 735d07f into master Jan 24, 2024
3 checks passed
@hannesdiedrich hannesdiedrich deleted the feature/GSYE-650-fix-order_updater branch February 28, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants