-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSYE-674: Change order of updating the time in the ProfileHandler and… #1727
Conversation
… cycling of the markets in the Simulation class
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
- Coverage 68.85% 68.59% -0.27%
==========================================
Files 145 145
Lines 13597 13598 +1
Branches 2020 2022 +2
==========================================
- Hits 9362 9327 -35
- Misses 3726 3753 +27
- Partials 509 518 +9 |
…and calculate the statistics only for the current opened, but ending market slot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bug/gsye 674 proposal2
… cycling of the markets in the Simulation class
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master