Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-674: Change order of updating the time in the ProfileHandler and… #1727

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

hannesdiedrich
Copy link
Member

@hannesdiedrich hannesdiedrich commented Jan 3, 2024

… cycling of the markets in the Simulation class

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master

… cycling of the markets in the Simulation class
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4c9cb08) 68.85% compared to head (5401dfb) 68.59%.
Report is 1 commits behind head on master.

❗ Current head 5401dfb differs from pull request most recent head 84c3b67. Consider uploading reports for the commit 84c3b67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   68.85%   68.59%   -0.27%     
==========================================
  Files         145      145              
  Lines       13597    13598       +1     
  Branches     2020     2022       +2     
==========================================
- Hits         9362     9327      -35     
- Misses       3726     3753      +27     
- Partials      509      518       +9     

spyrostz
spyrostz previously approved these changes Jan 29, 2024
Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesdiedrich hannesdiedrich merged commit a6d927b into master Jan 29, 2024
1 of 2 checks passed
@hannesdiedrich hannesdiedrich deleted the bug/GSYE-674 branch January 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants