Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Grid.js to 6.1 #418

Merged
merged 2 commits into from
Jan 14, 2024
+10 −11
Merged

Upgrade Grid.js to 6.1 #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb8849
gridjs 6.1
afshinm Jan 14, 2024
a264b70
update config
afshinm Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gridjs-react",
"version": "6.0.1",
"version": "6.1.0",
"description": "React component for Grid.js",
"main": "dist/gridjs.production.min.js",
"module": "dist/gridjs.production.es.min.js",
Expand Down Expand Up @@ -45,7 +45,7 @@
"eslint": "^8.22.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-jest": "^26.8.7",
"gridjs": "^6.0.1",
"gridjs": "^6.1.0",
"jest": "^27.5.1",
"jsdom": "^20.0.0",
"jsdom-global": "^3.0.2",
Expand Down
4 changes: 2 additions & 2 deletions src/grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as React from "react";
import { Component, createRef, RefObject } from "react";
import { Grid as Gridjs, UserConfig } from "gridjs";
import { Grid as Gridjs, Config } from "gridjs";

class Grid extends Component<Partial<UserConfig>, any> {
class Grid extends Component<Partial<Config>, any> {

Check warning on line 5 in src/grid.tsx

View workflow job for this annotation

GitHub Actions / build (14.x) 

Unexpected any. Specify a different type

Check warning on line 5 in src/grid.tsx

View workflow job for this annotation

GitHub Actions / build (16.x) 

Unexpected any. Specify a different type
private wrapper: RefObject<HTMLDivElement> = createRef();
// Grid.js instance
private readonly instance = null;
Expand Down
1 change: 0 additions & 1 deletion tests/grid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
expect(table.container.innerHTML).toMatchSnapshot();
});

//it("should receive the ready event", async () => {

Check warning on line 27 in tests/grid.test.tsx

View workflow job for this annotation

GitHub Actions / build (14.x) 

Some tests seem to be commented

Check warning on line 27 in tests/grid.test.tsx

View workflow job for this annotation

GitHub Actions / build (16.x) 

Some tests seem to be commented
// const table = render(
// <Grid data={[[1, 2, 3]]} columns={["a", "b", "c"]} width={"500px"} />
// );
Expand Down Expand Up @@ -68,7 +68,6 @@
columns={["a", "b", "c"]}
search={true}
pagination={{
enabled: true,
limit: 1,
}}
/>
Expand Down
Loading