Add SPDX identifiers, document S-O-B and SPDX #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As highlighted by reuse-tool, these were missing the copyright and licensing information. Since they are based on the ones we have in kmod - we inherit the same details. Signed-off-by: Emil Velikov <[email protected]>
Document the expectations around Signed-off-by, DCO and SPDX. Signed-off-by: Emil Velikov <[email protected]>
gregkh
approved these changes
Sep 24, 2024
gregkh
approved these changes
Sep 24, 2024
|
looks great, thanks! I don't want to add a copy of the DCO, let's just keep the link, that makes REUSE use simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested previously.
Note: the last file
.github/workflows/main.ymlwill come shortly, forgot it in my kmod PR.Would it make sense to have DCO in-tree, for transparency and archival (aka if we get v1.2, v2) purposes?
Reuse-tool would complain in that case, here is what the maintainer suggested [1] we can do. Any preferences?
[1] fsfe/reuse-tool#1075