🐛 When query parameter is disabled no redirect

When configuring the Authorization block and add the query parameter disabled, redirections stop working as expected
greenpau · May 10, 2022 · 46f5299 · 46f5299
1 parent 345e3d3
commit 46f5299
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/assets/cla/consent.yaml b/assets/cla/consent.yaml
@@ -16,3 +16,5 @@
   email: [email protected]
 - name: Pedro Flores
   email: [email protected]
+- name: Daniel Branco
+  email: [email protected]
diff --git a/pkg/authz/handlers/redirect.go b/pkg/authz/handlers/redirect.go
@@ -102,6 +102,8 @@ func configureRedirect(w http.ResponseWriter, r *http.Request, rr *requests.Auth
 		return
 	}
 
+	rr.Redirect.Enabled = true
+
 	if rr.Redirect.QueryDisabled {
 		return
 	}
@@ -115,8 +117,7 @@ func configureRedirect(w http.ResponseWriter, r *http.Request, rr *requests.Auth
 	} else {
 		rr.Redirect.URL = r.RequestURI
 	}
-
-	rr.Redirect.Enabled = true
+
 	rr.Redirect.Separator = "?"
 
 	if strings.Contains(rr.Redirect.AuthURL, "?") {