Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] CRJVM207 - 10 MILLIARDS - Customer data must have end-of-life information #170

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
corrections
btisPro committed Apr 6, 2023
commit 6a86ad08be10d020221eeafb4313d9918aa3b38e
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ public void visitNode(Tree tree) {
tree.accept(visitorInFile);
if (visitorInFile.hasANewCookieWithoutMaxDate())
{
reportIssue(tree, "RULE_MESSAGE");
reportIssue(tree, "Avoid not setting MaxAge");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message with a double negative is difficult to understand : please use a simple message like Giving a MaxAge is recommended

}
}

Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
import java.util.Collection;
import java.util.Collections;

class TestClass {
class TestClass {// Noncompliant {{Avoid not setting MaxAge}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why message presnet on class and not on each line of code with a non compliance ? I think this is that we should have.


public void NOK_CookieCreation() {
// create objet cookie