-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA] CRJVM207 - 10 MILLIARDS - Customer data must have end-of-life information #170
Open
saidmohamedali
wants to merge
22
commits into
green-code-initiative:main
Choose a base branch
from
saidmohamedali:CRJVM-JAVA
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−0
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
780e0b1
adding test file for Cookie without ExpirationCheck
5983df4
adding CookieWithoutExpirationRule
80260e3
adding CookieWithoutExpiration Test case
e599e50
adding MethodTree Exploration
824fa6b
parcours New Classe et SetMaxDate
btisPro 6a86ad0
corrections
btisPro 246bf4f
ajout d'un test
btisPro 5364c38
cast before !
j12t f43ffee
amélioration et commentaire code
btisPro f47ddfa
Merge branch 'main' into CRJVM-JAVA
saidmohamedali bd4c676
Removing unused import
f5af541
TODO
e700a16
Merge branch 'CRJVM-JAVA' of https://github.com/saidmohamedali/ecoCod…
abf6b0e
correcting code smell
547937d
correcting code smell
fe872fe
correcting code coverage
a4b7892
Applying review request
65540ca
Merge branch 'main' into CRJVM-JAVA
dedece35 9bb63b9
Merge branch 'main' into CRJVM-JAVA
dedece35 8c798a8
Merge branch 'main' into CRJVM-JAVA
dedece35 4005184
Merge branch 'main' into CRJVM-JAVA
dedece35 ae76a60
Merge branch 'main' into CRJVM-JAVA
dedece35 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
corrections
commit 6a86ad08be10d020221eeafb4313d9918aa3b38e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
import java.util.Collection; | ||
import java.util.Collections; | ||
|
||
class TestClass { | ||
class TestClass {// Noncompliant {{Avoid not setting MaxAge}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why message presnet on class and not on each line of code with a non compliance ? I think this is that we should have. |
||
|
||
public void NOK_CookieCreation() { | ||
// create objet cookie | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message with a double negative is difficult to understand : please use a simple message like
Giving a MaxAge is recommended