Fix & Improve MediaInfo::Tracks::Attributes.standardize_to_milliseconds. #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect results of MediaInfo::Tracks::Attributes.standardize_to_millisecond class method.
The 'minute' regex was triggered by some ms values & the regex used for the scan of the input string was not splitting elements not separated by a space.
Leading to these kind of results :
<Duration>4s 170ms</Duration>
4*1000 + 170 = 4170
previously wrong output : 10204000
<Duration>15s 164ms</Duration>
15*1000 + 164 = 15164
previously wrong output : 9855000
I also simplified the switch case by optimizing the regular expressions used for the hours / minutes / seconds, and added a support for iphone .mov specific duration format (ie.
164.536
)I'm joining a test & benchmark output for these updates : test_and_benchmark_output.txt